如果函数不返回false？

Question

I have the following click event:

$('#planung').click(function(){
    if($current != $('#planungtext')){
        console.log($current);
        console.log($('#planungtext'));
        $($current).removeClass('active');
        setTimeout(function(){$('#planungtext').addClass('active')}, 1000);
        $current = $('#planungtext');
    }
});

I used the log to see the contents of my variable and the '#planungtext' element. They are exactly the same, but the if function doesn't work as desired, as it is still going into it.

$current is not set before the first time the element is clicked.

Am I doing something wrong here?

Answer 1

The two jQuery objects point at the same DOM elements, but are different arrays (jQuery objects are essentially just arrays behind the scenes with extra stuff ).

Use jQuery is http://api.jquery.com/is/ to test if the same selector would match them:

if(!$current.is('#planungtext')){

The fastest way to do that check "manually" is:

if ($current[0].id !== '#planungtext'){

It is mentioned in comment that $current is a jQuery variable (good naming standard) but initially undefined in which case almost every solution posted will crash. You need to initialise $current to an empty jQuery object to give the most consistent behavior (jQuery objects should never be undefined to be used like that, else you need to re-wrap it. eg with $($current) which I do not recommend as a solution to an uninitialised jQuery variable):

var $current = $();   // $() returns an empty jQuery object

Answer 2

Assuming $current is another jQuery object, you can't compare objects like that. You can however compare their inner values. Change:

$current != $('#planungtext')

To:

$current[0] != $('#planungtext')[0]

Answer 3

If your comparing 2 html input element, you might want to check only the id attribute.

Since #planungtext is already a unique identifier.

$($current).attr('id') !== 'planungtext'