Bash CD到目录

Question

I am trying to change the extraction_sudir to a completely unrelated path to the file location (/home/user/downloads/tcomplete/foldername/file.mp4

#!/bin/bash
formats=(zip rar)
commands=([zip]="unzip -u" [rar]="unrar -o- e")
extraction_subdir='extracted'

downloadid=$1
downloadname=$2
downloadpath=$3

log()
{
    logger -t deluge-extractarchives "$@"
}

log "Download complete: $@"
cd "${downloadpath}"
for format in "${formats[@]}"; do
    while read file; do 
        log "Extracting \"$file\""
        cd "$(dirname "$file")"
        file=$(basename "$file")
        # if extraction_subdir is not empty, extract to subdirectory
        if [[ ! -z "$extraction_subdir" ]] ; then
            mkdir "$extraction_subdir"
            cd "$extraction_subdir"
            file="../$file"
        fi
        ${commands[$format]} "$file"
    done < <(find "$downloadpath/$downloadname" -iname "*.${format}" )
done

I thought it would be as simple as:

extraction_subdir='/home/user/extracted'

However that seems to just place the unrar'd file in the directory: /home/user/downloads/tcomplete/foldername/

I am looking at:

file=$(basename "$file")
...
file="../$file"

Being the cultprit but unsure how to solve this.

Edit:

Solved this my specifying the output in the unrar command eg:

${commands[$format]} "$file" "$extractedpath"

became:

${commands[$format]} "$file" "/home/user/extract"

Answer 1

You were correct in your analysis. The issue is that the script assumes that extraction_subdir is always within downloadpath .

I can't personally test it, but I believe the following will fix the issue:

file="${downloadpath}/${file}"

It will force the file path to be absolute instead of relative.