查找匹配范围并替换相邻的单元格值— Excel VBA

Question

I have two data sets that I need to compare--one that contains my master data set, and a second with corrected values for one variable in that data set.

For instance,

Data Set:

FirstName1 | LastName1 | UserID1 | etc1 | etc1  
FirstName2 | LastName2 | UserID2 | etc2 | etc2  
FirstName3 | LastName3 | UserID3 | etc3 | etc3

and so on.

However, the User ID column is incorrect and needs to be updated with values from a separate sheet:

FirstName1 | LastName1 | **Corrected**UserID1  
FirstName2 | LastName2 | **Corrected**UserID2  
FirstName3 | LastName3 | **Corrected**UserID3

and so on.

My objective is to find a match using the first two cells as criteria, then if a match is found, replace the User ID in the first sheet accordingly. Unfortunately, the original data set is much smaller (~3k rows) than the sheet where the corrections are coming from (~30k rows), so a simpler solution has not yet been identified.

My VBA skills are poor (typical, I know) and this is as far as I have come:

Sub FindReplace()
  Dim lr As Long, i As Long
  With Sheets("Data Set")
    lr = .Range("A:B").End(xlUp).Row
    For i = lr To 1
        If IsNumeric(Application.Match(.Range("A1:B1").Value, Sheets("Values").Range("A1:B1").Value, 0)) Then 
          .Cells("C1").Value = Sheets("Values").Cells("C1")
        End If
    Next i
  End With
End Sub

However, this doesn't do anything and I'm a bit stumped (and over my head). Ideally, I would appreciate some additional explanation of why the above doesn't work so that I might learn from my mistakes, but any help at all is infinitely appreciated.

Many thanks for the assistance!

+ds

Answer 1

Without getting into building and testing this, I can see that you have a typo.

Sub FindReplace()
Dim lr As Long, i As Long
With Sheets("Data Set")
    lr = .Range("A:B").End(xlUp).Row
    **For i = lr To 1**
        If IsNumeric(Application.Match(.Range("A1:B1").Value, Sheets("Values").Range("A1:B1").Value, 0)) Then .Cells("C1").Value = Sheets("Values").Cells("C1")
    Next i
End With
End Sub

Should be

    For i = 1 To lr

Answer 2

As Alex stated, you don't need VBA, a VLookup will work just fine. You can concatenate both criteria into a third column on both sheets, then vlookup against that value.

Just make sure your concatenated column is at the left of the ID that you would like to retrieve.

FirstName1LastName1 |FirstName1 | LastName1 | CorrectedUserID1
FirstName2LastName2 |FirstName2 | LastName2 | CorrectedUserID2
FirstName3LastName3 |FirstName3 | LastName3 | CorrectedUserID3

Once you get your IDs updated, hard-code the formulas with a copy/pastespecial:values, and delete the concatenated column.