检查foreach循环列表结果C＃

Question

I have this bit of code in a class:

public class TicketSummary
    {

        //get all the development tickets
        public List<IncidentSummary> AllDevelopmentTickets { get; set; }
      public List<string> TicketNames()
        {
            List<string> v = new List<string>();

            foreach (var developmentTicket in AllDevelopmentTickets)
            {
                var ticketIds = developmentTicket.id.ToString(CultureInfo.InvariantCulture);
                v.Add(ticketIds);
            }

            return v;
        }  
    }
}

And I am trying to see if my API connection (plus all the code) did it's job and pulls back the tickets and their info, more specifically the ids.

In my main program I have no clue how to check if it did the job. I tried something but it isn't quite right and doesn't return anything ( I know I need a Console.WriteLine)

        static void Main(string[] args)
        {

            Console.ReadLine();


            var tickets = new TicketSummary();
            tickets.TicketNames();
            while ( tickets != null )
            {
                Console.WriteLine(tickets);
            }

        }

Any suggestions, please?

Thank you!

Answer 1

You've dropped the returned result: tickets.TicketNames(); returns List<String> that you have to assign and then itterate :

 var tickets = new TicketSummary();
 var names = tickets.TicketNames(); // <- names, List<String> according to the code

 // printing out all the names
 foreach(var name in names)   
   Console.WriteLine(name);

Answer 2

Do you mean you just want to print all the tickets out?

foreach (var ticket in tickets.TicketNames())
{
    Console.WriteLine(ticket);
}

Answer 3

You have several problems in your code, that should keep it from even compiling, but aside from that, It seem's what you're really after is rather transforming the data in AllDevelopmentTickets , rather than moving it somewhere. So you could probably do it with a Select call (from LINQ). So, in your main method:

var tickets = new TicketSummary();
// add some tickets to tickets.AllDevelopmentTickets here...

var ticketNames = tickets.AllDevelopmentTickets.Select(ticket => ticket.id.ToString();
// Yes, you should probably use an UI culture in the ToString call. 
// I'm just trying to limit my line width =)

Now, ticketNames should be an IEnumerable<string> holding all the ticket ids. To, for example, print them out, you can iterate over them and write to console output:

foreach (var name in ticketNames) {
    Console.WriteLine(name);
}

Answer 4

You're ignoring the returned value.

static void Main(string[] args)
    {

        Console.ReadLine();


        var tickets = new TicketSummary();
        var res = tickets.TicketNames();
        while ( for r in res )
        {
            Console.WriteLine(r);
        }

    }

Answer 5

You need to assign / use the return value of the TicketNames() method. This seems a lot of work just to return the string version of the TicketId. This can be reduced

public List<string> TicketNames()
{
    return AllDevelopmentTickets
        .Select(t => t.id.ToString(CultureInfo.InvariantCulture))
        .ToList();
}  

   var ticketSummary = new TicketSummary();
   var ticketNames = ticketSummary.TicketNames();

    foreach(var ticketName in ticketNames)
    {
        Console.WriteLine(ticketName);
    }

or Even just:

  foreach(var ticketName in AllDevelopmentTickets
        .Select(t => t.id.ToString(CultureInfo.InvariantCulture)))
  {
      Console.WriteLine(ticketName);
  }