从函数内集成变量

Question

I am having troubles getting the total hours needed depending on method of transport.

This is my first code as a lesson to familiarize myself with coding.

Javascript:

$(document).ready(function() {

$('#calculateTotal').click(function () {


var a = ($('#car').val()) ? parseInt($('#car').val()) : 0;

var c = ($('#bus').val()) ? parseInt($('#bus').val()) : 0;


 document.getElementById("qr1").onclick = function() {
    if (this.checked) {
        var b = 1;
    }
    else {
        b = 0;
    }
};

var totalTime = a+b+c;

$('#total').html(totalTime);


});

});

var b is not being recognized as a variable when I click on Calculate Total. Can anyone show me the way as to how to declare var b in a way that makes sense in coding?

Thank you.

Answer 1

You are declaring "b" inside of a function.

Because you want it to be globaly accessible outside of the function it was created in, remove the var from in front of it in the first statement.

document.getElementById("qr1").onclick = function() {
    if (this.checked) {
        b = 1;
    }
    else {
        b = 0;
    }
};

Alternatively you could set b outside of the function to 0

b = 0;

then

document.getElementById("qr1").onclick = function() {
    if (this.checked) {
        b = 1;
    }
};

As an aside, global s are usually frowned upon (I use them a lot) so you could create an object to house everything. This way you are nice and tidy.

Also, as mentioned in the comments, the qr1 click handler should be placed outside of the calculate total function.