在Objective-c中的switch案例中的if语句

Question

I know there are a couple of questions like this on stack overflow but the problem is that it does not solve my answer.

I want to show an if-statement inside a switch case.

Here is my code

 NSMutableArray *stdMarks = [[NSMutableArray alloc]initWithObjects:@"100", @"70", @"97", @"11", @"59", nil];

    int marksObtained;

    for (int i= 0; i < [stdMarks count]; i++) {
        marksObtained += [[stdMarks objectAtIndex:i] integerValue];
    }

    int totalMarks = 500;
    int percentage = (marksObtained * 100)/totalMarks;

    NSLog(@"The total marks are: %d", marksObtained);
    NSLog(@"The percentage is: %d", percentage);
    NSLog(@"The total numbers of subjects are: %d", [stdMarks count]);


    switch (percentage) {
        case 1:
            if (percentage >= 70) {
                NSLog(@"You get 50 percent fee concession");
            }
            break;
        case 2:
            if (percentage >= 60) {
                NSLog(@"You get 45 percent fee concession");
            }
            break;
        default:
            NSLog(@"you do not qualify");
            break;
    }

No matter what the percentage is I always get the default answer "You do not qualify".

What am I doing wrong

Please help me out here

Answer 1

that is because the switch is being fed the percentage which only caters for 1 and 2 percent, so those if statements will never fire because to get into those cases, they have to be lower then the values in the if statements

my suggestion is to drop the switch statement, because it seems unnecessary, just have if/else statements that encompass the ranges you want

Answer 2

In your code, if your percentage is not equal to run 1 or 2, it will go to default.

switch (percentage) { <---- this percentage, you only provide the case of 1 and 2.
        case 1:
            if (percentage >= 70) {
                NSLog(@"You get 50 percent fee concession");
            }
            break;
        case 2:
            if (percentage >= 60) {
                NSLog(@"You get 45 percent fee concession");
            }
            break;
        default:
            NSLog(@"you do not qualify");
            break;
    }

guessing you need to change the percentage in switch(percentage).

Updated:

if (percentage >= 70) {
    NSLog(@"You get 50 percent fee concession");
}
else if (percentage >= 60) {
    NSLog(@"You get 45 percent fee concession");
}
else{
    NSLog(@"you do not qualify");
}

update: if you want to do it using switch case: for percentage >= 70

switch (percentage)
case 70:
case 71:
case 72:
case 73:
.
.
.
case 100:
NSLog(@"You get 50 percent fee concession");
break;
case 60:
.
.
.

and so on which is very stupid , so a if else case is more suitable