在对话框的按钮上单击从ListView删除行

Question

I am trying to delete a row in listview as well as from database when user dialogue box is shown to use user while pressing for long time.

I have tried following code:

Place.java (For model - getter and setter methods)

public class Place {
    int _id;
    private String mname;
    private double mlatitude,mlongitude;
    private String mplacedetails;

    public Place(int id, String name, double latitude, double longitude,String placedetails)
        {
            this._id = id;
          mname = name;
          mlatitude = latitude;
          mlongitude = longitude;
          mplacedetails = placedetails;


    }

    public Place(String name, double latitude, double longitude,String placedetails)
    {

        mname = name;
        mlatitude = latitude;
        mlongitude = longitude;
        mplacedetails = placedetails;

    }

    public Place() {

    }
    public int getID(){
        return this._id;
    }


    public void setID(int id){
        this._id = id;
    }

    public void setname(String placename)
    {
        mname = placename;


    }

    public String getname()
    {
        return mname;


    }

    public void setlatitude(double latitude)
    {
        mlatitude=latitude;


    }

    public double getlatitude()
    {
        return mlatitude;


    }


    public void setlongitude(double longitude)
    {
        mlongitude = longitude;


    }

    public double getlongitude()
    {
        return mlongitude;


    }


    public void  setPlacedetails(String placedetails)
    {

        mplacedetails = placedetails;
    }


    public String getplacedetails()
    {
        return mplacedetails;
    }


}

PlaceAdapter.java - for adapter of ListView listview_places

public class PlacesAdapter extends ArrayAdapter<Place>{

    Context mcontext;
    int mlayoutResourceId;
  List<Place> mdata = null;
    View row;


    public PlacesAdapter(Context context, int layoutResourceId, List<Place> data) {
        super(context, layoutResourceId, data);
        mlayoutResourceId = layoutResourceId;
        mcontext = context;
        mdata = data;
    }

    @Override
    public View getView(final int position, View convertView, ViewGroup parent) {
        row = convertView;
        PlaceHolder holder = null;

        if(row == null)
        {
            LayoutInflater inflater = ( (Activity) mcontext).getLayoutInflater();
            row = inflater.inflate(mlayoutResourceId, parent, false);

            holder = new PlaceHolder(row);


            row.setTag(holder);
            Log.d("my","new row is inflated for listview current position");

        }
        else
        {
            holder = (PlaceHolder)row.getTag();
            Log.d("my","row is taken from the holder");
        }

        Place p = mdata.get(position);
        holder.txt_place_title.setText(p.getname());
        holder.txt_place_details.setText(p.getplacedetails());

        return row;
    }

    class PlaceHolder
    {
        TextView txt_place_title;
        TextView txt_place_details;


        public PlaceHolder(View v){

            txt_place_title = (TextView)row.findViewById(R.id.txt_Place_Title);
            txt_place_details = (TextView)row.findViewById(R.id.txt_Place_Details);

        }
    }
}

MySQLiteHelper.java - for databse controller

public class MySqliteHelper extends SQLiteOpenHelper{

    private static final int DATABASE_VERSION = 1;

    private static final String DATABASE_NAME = "MyApplicationDatabase";

    private static final String KEY_ID = "id";
    private static final String KEY_PLACENAME = "placename";
    private static final String KEY_PLACEDETAILS = "placedetails";
    private static final String KEY_LATITUDE = "latitude";
    private static final String KEY_LONGITUDE = "longitude";

    private static final String TABLE_NAME = "places";


    public MySqliteHelper(Context context) {
        super(context, DATABASE_NAME,null, DATABASE_VERSION);


    }

    @Override
    public void onCreate(SQLiteDatabase db) {



        //actual query = create table places (id primary key autoincrement, placename taxt, latitude real, longitude real);
        String query =  "CREATE TABLE " +TABLE_NAME + "( " + KEY_ID+
                " INTEGER PRIMARY KEY, " + KEY_PLACENAME+
                " TEXT, "+ KEY_PLACEDETAILS+
                " TEXT, "+ KEY_LATITUDE+
                " REAL, "+KEY_LONGITUDE+ " REAL)";


                db.execSQL(query);
                Log.d("my", "Successfully created table: " + query);



    }



    @Override
    public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
        db.execSQL("DROP TABLE IF EXISTS places");

        this.onCreate(db);
    }


    public void addPlaces(Place place)
    {

        SQLiteDatabase db = this.getWritableDatabase();

        ContentValues convalues = new ContentValues();



        convalues.put(KEY_PLACENAME,place.getname());
        convalues.put(KEY_LATITUDE,place.getlatitude());
        convalues.put(KEY_LONGITUDE,place.getlongitude());
        convalues.put(KEY_PLACEDETAILS,place.getplacedetails());

          db.insert(TABLE_NAME, null, convalues);
          Log.d("my","db.insert(TABLE_NAME, null, convalues)");
          Log.d("my", "Values inserted");
          db.close();

    }

    public Place getPlace(int id) {
        Place place = null;
        SQLiteDatabase db = this.getReadableDatabase();

        Cursor cursor = db.query(TABLE_NAME, new String[]{KEY_ID, KEY_LATITUDE, KEY_LONGITUDE,
                        KEY_PLACENAME, KEY_PLACEDETAILS}, KEY_ID + "=?",
                new String[]{String.valueOf(id)}, null, null, null, null);
        if (cursor != null) {
            cursor.moveToFirst();
        }
        place = new Place(cursor.getInt(cursor.getColumnIndex("_ID")), cursor.getString(cursor.getColumnIndex(KEY_PLACENAME)),
                    cursor.getDouble(cursor.getColumnIndex(KEY_LATITUDE)), cursor.getDouble(cursor.getColumnIndex(KEY_LONGITUDE)), cursor.getString(cursor.getColumnIndex(KEY_PLACEDETAILS)));

        cursor.close();
        db.close();

        return place;
    }

    public List<Place> getAllPlaces() {
   List<Place> placeList = new ArrayList<Place>();



        SQLiteDatabase db = this.getWritableDatabase();

        String selectQuery = "SELECT  * FROM " + TABLE_NAME;

        Cursor cursor = db.rawQuery(selectQuery, null);
        Log.d("my","query fired");
        Log.d("my",cursor.toString());

        if (cursor.moveToFirst()) {

            Log.d("my","in movetofirst()");

            do {

                Log.d("my","in do");
                Place place = new Place();

                place.setname(cursor.getString(cursor.getColumnIndex(KEY_PLACENAME)));
                place.setlatitude(cursor.getDouble(cursor.getColumnIndex(KEY_LATITUDE)));
                place.setlongitude(cursor.getDouble(cursor.getColumnIndex(KEY_LONGITUDE)));
                place.setPlacedetails(cursor.getString(cursor.getColumnIndex(KEY_PLACEDETAILS)));

                placeList.add(place);
            } while (cursor.moveToNext());
        }


        return placeList;
    }

    public void deletePlaces(Place place)
    {

        SQLiteDatabase db = this.getWritableDatabase();



        db.delete(TABLE_NAME, KEY_ID + " = ?",
                new String[] { String.valueOf(place.getID()) });
        db.close();
    }

    public int updatePlaces(Place place) {
        SQLiteDatabase db = this.getWritableDatabase();

        ContentValues values = new ContentValues();
        values.put(KEY_PLACENAME, place.getname());
        values.put(KEY_PLACEDETAILS, place.getplacedetails());


        return db.update(TABLE_NAME, values, KEY_ID + " = ?",
                new String[] { String.valueOf(place.getID()) });
    }

    public void deleteByName(String name) {
        SQLiteDatabase db= this.getWritableDatabase();
        db.delete(TABLE_NAME, KEY_PLACENAME +"=?", new String [] { name });
        db.close();
    }

}

and ShowPlaces.java Activity has fragment named PlaceholderFragment.java : - where adapter is set to listview_places and dialogue box is shown on itemlongclick.

public class PlaceholderFragment extends Fragment {
        public ListView listview_places;

        public PlaceholderFragment() {
        }

        @Override
        public View onCreateView(LayoutInflater inflater, ViewGroup container,
                                 Bundle savedInstanceState) {
            View rootView = inflater.inflate(R.layout.fragment_show_place, container, false);



            MySqliteHelper db = new MySqliteHelper(getActivity().getBaseContext());

           List<Place> places = db.getAllPlaces();




            for (Place p : places){
                String log = "name:" +p.getname() + " ,details: " + p.getplacedetails();

                Log.d("my", log);
            }

            listview_places = (ListView)rootView.findViewById(R.id.listView_places);

            final PlacesAdapter places_adapter = new PlacesAdapter(getActivity(),R.layout.listview_item_row,places);

            Log.d("my", "adapter constructor is working");

            listview_places.setAdapter(places_adapter);



            listview_places.setLongClickable(true);

            listview_places.setOnItemLongClickListener(new AdapterView.OnItemLongClickListener() {

                public boolean onItemLongClick(AdapterView<?> parent, View view,
                                               final int pos, long id) {

                    new AlertDialog.Builder(getActivity())
                            .setTitle("Delete Place")
                            .setMessage("Are you sure you want to delete this place?")
                            .setPositiveButton("Delete", new DialogInterface.OnClickListener() {
                                public void onClick(DialogInterface dialog, int which) {

                                }
                            })
                            .setNegativeButton(android.R.string.no, new DialogInterface.OnClickListener() {
                                public void onClick(DialogInterface dialog, int which) {
                                    // do nothing
                                }
                            })
                            .setIcon(android.R.drawable.ic_menu_delete)
                            .show();

                    return true;
                }
            });

db.close();
        return rootView;
        }

    }

What I want to do is to to delete the row in listview_places as well as from database when user clicks on delete button in DialougeBox.

For database as you can see there is already a method named deleteByName() in MySQLiteHelper.java .

So, thinks looks much more complex too me...I can say what I want to do is that I want to invoke deleteByName method of MySQLiteHelpder and remove method of ListView list_view_places in between

    .setPositiveButton("Delete", new DialogInterface.OnClickListener() {
                                        public void onClick(DialogInterface dialog, int which) {

//I want to delete place from listview and database here.
                                        }
                                    })

I have tried many times something like:

 nameArray.remove(position);

        // dh.Deleteitem();
            adapter.notifyDataSetChanged();
            adapter=new ListAdapter(getActivity(), nameArray);
         list.setAdapter(adapter);

But..sometimes it didn't work showing that adapter should be final if it is accessed from inner class . and if I make adapter final than showing notifyDatasetChanged can not be resolved .

What should I do?

Answer 1

Now I solved it!

After working for hours, I found solution for this:

Inside my listview onItemClickListener and then inside dialogue box's positive button onclick, I used,

                            Place place = places_adapter.getItem(pos);
                            places_adapter.remove(place);
                            db.deletePlaces(place);
                            places_adapter.notifyDataSetChanged();

You need to only remove from adapter . Adapter works as controller. At last don't forget notifyDataSetChanged() .

whole code:

  listview_places.setOnItemLongClickListener(new AdapterView.OnItemLongClickListener() {
       new AlertDialog.Builder(getActivity())
                                .setTitle("Delete Place")
                                .setMessage("Are you sure you want to delete this place?")
                                .setPositiveButton("Delete", new DialogInterface.OnClickListener() {
                                    public void onClick(DialogInterface dialog, int which) {

                                        Place place = places_adapter.getItem(pos);
                                        places_adapter.remove(place);
                                        db.deletePlaces(place);
                                        places_adapter.notifyDataSetChanged();

                                    }
                                })
});

Answer 2

First off, don't create your MySqliteHelper in a life cycle method of a View Component like a Fragment, unless you're really sure you won't need it anywhere else and kniw what you're doing. Better create it inside the Application class and access it with App.inst().yourDbMngr().delete(Place.class, placeToDelete) . Then you won't need to think about member vars when deleting pojos. Also make your adapter a member var of the fragment hoatung it, as you'd likely access it quite often. onCreate() is the right place to do so. :)