rails 4 ruby​​条件基于ENV var和Rails.env.production？

Question

I am trying to setup a few global helper decision functions that look like this:

  def send_email_to_external_service
    ENV['SEND_EMAIL_TO_EXTERNAL_SERVICE']? true : false
  end

This works great for development, but obviously, I do not want to have to pass these parameters in for production so I had to roll with:

  def send_email_to_external_service
    active = ENV['SEND_EMAIL_TO_EXTERNAL_SERVICE']? true : false
    active = true if Rails.env.production?
    return active
  end

Would there be a better way of structuring this function ie is a single line possible?

Answer 1

I would just do something like this:

def send_email_to_external_service
  Rails.env.production? || ENV['SEND_EMAIL_TO_EXTERNAL_SERVICE']
end