图像未加载到轮播中

Question

i have a carousel on my website and wish to load images from database, although the carousel is working fine, but the images are not loading

Database View

    id    image1                   image2               image3
    1  carouselimage/image1  carouselimage/image1   carouselimage/image1

there wouldbe only one row in this table

code for carousel

 <?php
        require 'connection.php';
            echo "<header id='myCarousel' class='carousel slide'>";
                echo "<ol class='carousel-indicators'>";
                    echo "<li data-target='#myCarousel' data-slide-to='0' class='active'></li>";
                    echo "<li data-target='#myCarousel' data-slide-to='1'></li>";
                    echo "<li data-target='#myCarousel' data-slide-to='2'></li>";
                echo "</ol>";

                echo "<div class='carousel-inner'>";

                    $sql = "SELECT * FROM carousel_image ";

                    $result = mysqli_query($con, $sql);
                    if (mysqli_num_rows($result) > 0) 
                        {
                            while($row = mysqli_fetch_array($result)) 
                                {
                                    $image1=$row['image1'];
                                    $image2=$row['image2'];
                                    $image3=$row['image3'];

                                    echo "<div class='item active'>";
                                        echo "<div class='fill' style='background-image:url('http://example.com/carouselimage/" .$image1."\' height=\'500\' width=\'2000\'/);></div>";
                                    echo "</div>";

                                    echo "<div class='item'>";
                                        echo "<div class='fill' style='background-image:url('http://example.com/carouselimage/" .$image2."\' height=\'500\' width=\'2000\'/);></div>";
                                    echo "</div>";

                                    echo "<div class='item'>";
                                        echo "<div class='fill' style='background-image:url('http://example.com/carouselimage/" .$image3."\' height=\'500\' width=\'2000\'/);></div>";
                                    echo "</div>";
                                }
                        }
                echo "</div>";  

                echo "<a class='left carousel-control' href='#myCarousel' data-slide='prev'>";
                    echo "<span class='icon-prev'></span>";
                echo "</a>";
                echo "<a class='right carousel-control' href='#myCarousel' data-slide='next'>";
                    echo "<span class='icon-next'></span>";
                echo "</a>";
            echo "</header>";

            mysqli_close($con); 
    ?>

would appreciate if someone could help me with the code

Answer 1

Your problem is probably not the SQL, but this line of PHP/HTML and CSS:

echo "<div class='fill' style='background-image:url('http://example.com/carouselimage/" .$image1."\' height=\'500\' width=\'2000\'/);></div>";
                              ^ a ' opens style and ^ this ' closes style again

So you gotta fix your quotes, and as well:

echo "<div style='[..]height=\'500\' width=\'2000\'/);></div>";
           ^^^^^^^^^^^^^^^^^ height/width within style="" shouldn't have = or a quote

Honestly this is basic HTML/CSS, so I would advise you to look at w3schools to learn how to prevent these mistakes. It should be something like this:

echo '<div class="fill" style="background-image:url(http://example.com/carouselimage/' . $image1 . ');height:500px;width:2000px;"></div>';