从TextView设置文本时Android应用程序崩溃

Question

I've searched thoroughly through stackoverflow for a solution to my problem, however so I was unsuccessful so I must resort to asking the question myself. My issues is that when I

Songname.setText(Fullname);

My app crashes. If I comment out the code then the app does not crash. My Fullname variable is

Fullname = (artist + ":" + album + ":" + track);

which comes from a BroadcastReceiver:

    private BroadcastReceiver mReceiver = new BroadcastReceiver() {

    @Override
    public void onReceive(Context context, Intent intent) {
        String action = intent.getAction();
        String cmd = intent.getStringExtra("command");
        Log.v("tag ", action + " / " + cmd);
        String artist = intent.getStringExtra("artist");
        String album = intent.getStringExtra("album");
        String track = intent.getStringExtra("track");
        Log.v("tag", artist + ":" + album + ":" + track);
        Fullname = (artist + ":" + album + ":" + track);
        Toast.makeText(MusicPlayer.this, track, Toast.LENGTH_SHORT).show();
        update();

    }
};

(I think) I have my TextView set up correctly so I doubt that is the issue but I'll post it just in case:

TextView Songname;    
TextView Songname = (TextView) findViewById(R.id.musictitle);

Here is the entire xml just in case that is the issue:

<?xml version="1.0" encoding="utf-8"?>

<TextView
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:textAppearance="?android:attr/textAppearanceLarge"
    android:text="Large Text"
    android:id="@+id/musictitle"
    android:layout_marginTop="46dp"
    android:ellipsize="marquee"
    android:scrollHorizontally="true"
    android:focusable="true"
    android:focusableInTouchMode="true"
    android:layout_alignParentTop="true"
    android:layout_alignParentLeft="true" />

<Button
    android:layout_width="50dp"
    android:layout_height="50dp"
    android:text="New Button"
    android:id="@+id/button"
    android:layout_alignBottom="@+id/imageView"
    android:layout_toLeftOf="@+id/imageView"
    android:layout_marginRight="25dp" />

<Button
    android:layout_width="50dp"
    android:layout_height="50dp"
    android:text="New Button"
    android:id="@+id/button2"
    android:layout_alignTop="@+id/button"
    android:layout_alignParentLeft="true"
    android:layout_marginLeft="35dp" />

<Button
    android:layout_width="50dp"
    android:layout_height="50dp"
    android:text="New Button"
    android:id="@+id/button3"
    android:layout_alignTop="@+id/textView7"
    android:layout_toLeftOf="@+id/textView7" />

<Button
    android:layout_width="50dp"
    android:layout_height="50dp"
    android:text="New Button"
    android:id="@+id/button4"
    android:layout_alignTop="@+id/textView7"
    android:layout_toRightOf="@+id/seekBar" />

<TextView
    android:layout_width="50dp"
    android:layout_height="50dp"
    android:textAppearance="?android:attr/textAppearanceLarge"
    android:text="0"
    android:id="@+id/textView7"
    android:gravity="center"
    android:layout_gravity="center"
    android:layout_alignBottom="@+id/imageView"
    android:layout_toLeftOf="@+id/button4" />

<SeekBar
    android:layout_width="500dp"
    android:layout_height="wrap_content"
    android:id="@+id/seekBar"
    android:indeterminate="false"
    android:layout_below="@+id/musictitle"
    android:layout_centerHorizontal="true"
    android:layout_marginTop="30dp" />

<ImageView
    android:layout_width="180dp"
    android:layout_height="180dp"
    android:id="@+id/imageView"
    android:layout_below="@+id/seekBar"
    android:layout_centerHorizontal="true"
    android:layout_marginTop="24dp" />

and the class file if that is the issue:

package com.androidddev101.ep8;


import android.app.Activity;
import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.text.TextUtils;
import android.util.Log;
import android.view.View;

import android.content.IntentFilter;
import android.widget.TextView;
import android.widget.Toast;


public class MusicPlayer extends Activity implements View.OnClickListener {

    public static final String SERVICECMD = "com.android.music.musicservicecommand";
    String Fullname;
String artist, album, track;
TextView Songname;
@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.musicplayer);


    TextView Songname = (TextView) findViewById(R.id.musictitle);

    IntentFilter iF = new IntentFilter();
    iF.addAction("com.android.music.metachanged");
    iF.addAction("com.android.music.playstatechanged");
    iF.addAction("com.android.music.playbackcomplete");
    iF.addAction("com.android.music.queuechanged");
    iF.addAction("com.htc.music.metachanged");
    iF.addAction("fm.last.android.metachanged");
    iF.addAction("com.sec.android.app.music.metachanged");
    iF.addAction("com.nullsoft.winamp.metachanged");
    iF.addAction("com.amazon.mp3.metachanged");
    iF.addAction("com.miui.player.metachanged");
    iF.addAction("com.real.IMP.metachanged");
    iF.addAction("com.sonyericsson.music.metachanged");
    iF.addAction("com.rdio.android.metachanged");
    iF.addAction("com.samsung.sec.android.MusicPlayer.metachanged");
    iF.addAction("com.andrew.apollo.metachanged");
    iF.addAction("com.jrtstudio.AnotherMusicPlayer.metachanged");


    registerReceiver(mReceiver, iF);
}




private BroadcastReceiver mReceiver = new BroadcastReceiver() {

    @Override
    public void onReceive(Context context, Intent intent) {
        String action = intent.getAction();
        String cmd = intent.getStringExtra("command");
        Log.v("tag ", action + " / " + cmd);
        String artist = intent.getStringExtra("artist");
        String album = intent.getStringExtra("album");
        String track = intent.getStringExtra("track");
        Log.v("tag", artist + ":" + album + ":" + track);
        Fullname = (artist + ":" + album + ":" + track);
        Toast.makeText(MusicPlayer.this, track, Toast.LENGTH_SHORT).show();
        update();

    }
};

public void update() {
    {
       // Fullname = (artist + ":" + album + ":" + track);
        Log.v("tag", Fullname + "123");
        Songname.setText(Fullname);
        Songname.setSelected(true);
        Songname.setEllipsize(TextUtils.TruncateAt.MARQUEE);
        Songname.setSingleLine(true);
    }
}

@Override
public void onClick(View v) {

}

}

Note: The toast message works and gives me the the track name

Here is the error from Logcat

Caused by: java.lang.NullPointerException at com.androidddev101.ep8.MusicPlayer.update(MusicPlayer.java:81) at com.androidddev101.ep8.MusicPlayer$1.onReceive(MusicPlayer.java:72)

Thank you for any assistance possible.

Answer 1

TextView Songname; // not instantiated for global use
TextView Songname = (TextView) findViewById(R.id.musictitle); // instantiated in only oncreate

change it to this

TextView Songname;    
Songname = (TextView) findViewById(R.id.musictitle);

Answer 2

The reference of Songname is local to onCreate, you don't need to declare another variable called Songname.

package com.androidddev101.ep8;


import android.app.Activity;
import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.text.TextUtils;
import android.util.Log;
import android.view.View;

import android.content.IntentFilter;
import android.widget.TextView;
import android.widget.Toast;


    public class MusicPlayer extends Activity implements View.OnClickListener {

      public static final String SERVICECMD = "com.android.music.musicservicecommand";
      String Fullname;
      String artist, album, track;
      TextView Songname;

      @Override
      public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.musicplayer);


        Songname = (TextView) findViewById(R.id.musictitle);

        IntentFilter iF = new IntentFilter();
        iF.addAction("com.android.music.metachanged");
        iF.addAction("com.android.music.playstatechanged");
        iF.addAction("com.android.music.playbackcomplete");
        iF.addAction("com.android.music.queuechanged");
        iF.addAction("com.htc.music.metachanged");
        iF.addAction("fm.last.android.metachanged");
        iF.addAction("com.sec.android.app.music.metachanged");
        iF.addAction("com.nullsoft.winamp.metachanged");
        iF.addAction("com.amazon.mp3.metachanged");
        iF.addAction("com.miui.player.metachanged");
        iF.addAction("com.real.IMP.metachanged");
        iF.addAction("com.sonyericsson.music.metachanged");
        iF.addAction("com.rdio.android.metachanged");
        iF.addAction("com.samsung.sec.android.MusicPlayer.metachanged");
        iF.addAction("com.andrew.apollo.metachanged");
        iF.addAction("com.jrtstudio.AnotherMusicPlayer.metachanged");


        registerReceiver(mReceiver, iF);
    }


    private BroadcastReceiver mReceiver = new BroadcastReceiver() {

      @Override
      public void onReceive(Context context, Intent intent) {
        String action = intent.getAction();
        String cmd = intent.getStringExtra("command");
        Log.v("tag ", action + " / " + cmd);
        String artist = intent.getStringExtra("artist");
        String album = intent.getStringExtra("album");
        String track = intent.getStringExtra("track");
        Log.v("tag", artist + ":" + album + ":" + track);
        Fullname = (artist + ":" + album + ":" + track);
        Toast.makeText(MusicPlayer.this, track, Toast.LENGTH_SHORT).show();
        update();

       }
      };

      public void update() {
        {
          // Fullname = (artist + ":" + album + ":" + track);
          Log.v("tag", Fullname + "123");
          Songname.setText(Fullname);
          Songname.setSelected(true);
          Songname.setEllipsize(TextUtils.TruncateAt.MARQUEE);
          Songname.setSingleLine(true);
        }
      }

      @Override
      public void onClick(View v) {

      }
    }