使用Moq进行交互单元测试

Question

I have a testing class

    public class TerminationRequestValidation : ValidatorBase<TerminationRequest>
{
    public TerminationRequestValidation(IIntHR2BLLContext context) : base(context)
    {
    }

    public override ValidationResult ValidateWithoutThrow(TerminationRequest request)
    {
        var result = ValidationResult.Success;

        /* some logic */

        var isHRIAdvanced = Context.Logics.Accessible.HasAccess(request, IntHRSecurityOperationCode.TerminationRequestSetTerminationDateBehindhand);

        if (!isHRIAdvanced && Context.Logics.Termination.IsTerminationDateChanged(request))
        {
            result += CheckTerminationDate(request);                
        }

        return result;
    }

    public virtual ValidationResult CheckTerminationDate(TerminationRequest request)
    {
        var result = ValidationResult.Success;

        /* any validation logic */

        return result;
    }
}

I need to check 'CheckTerminationDate' method is performed

        [TestMethod]
    public void Validate_TerminationDateChangedbyNotAdvanced_TerminationDateCheck()
    {
        var context = FakeContext.Create();
        // first stub
        var accessibleBllStub = new Mock<IAccessibleBLL>(MockBehavior.Loose);

        accessibleBllStub.Setup(z => z.HasAccess(It.IsAny<TerminationRequest>(), It.IsAny<IntHRSecurityOperationCode>()))

            .Returns<TerminationRequest, IntHRSecurityOperationCode>((x, y) => y != IntHRSecurityOperationCode.TerminationRequestSetTerminationDateBehindhand);

        context.StubBLL(z => z.Accessible, accessibleBllStub.Object);
        // second stub
        var terminationBLLStub = new Mock<ITerminationBLL>(MockBehavior.Loose);

        terminationBLLStub.Setup(z => z.IsTerminationDateChanged(It.IsAny<TerminationRequest>())).Returns(true);

        context.StubBLL(z => z.Termination, terminationBLLStub.Object);
        // mock
        var validator = new Mock<TerminationRequestValidation>(MockBehavior.Loose, context.MainContext);
        // act
        validator.Object.ValidateWithoutThrow(termination);
        //assert
        validator.Verify(z => z.CheckTerminationDate(It.IsAny<TerminationRequest>()));
    }

This unit test off course isn't work. On the one hand I need to call real 'ValidateWithoutThrow' method, on the another hand I need to check that stub method 'CheckTerminationDate' is performed.

Guys, help me to find the best solution! May be I need to redesign testing class to make in more testable

Answer 1

I need to check 'CheckTerminationDate' method is performed

You don't. You need to test that the request was validated. Whether that's done inline, or by calling CheckTerminationDate , or by calling some other method, that's an implementation detail - and unit tests don't care about that.

So, your tests should look something like this:

public void ValidateWithoutThrow_ReturnsSucessfulResult_When_RequestIsValid() 
{
    var validRequest = //...
    var validator = new TerminationRequestValidation(/*...*/); // don't mock this class

    var result = validator.TerminationRequestValidation(validRequest);

    Assert.Equal(ValidationResult.Success, result);
}

public void ValidateWithoutThrow_ReturnsUnsucessfulResult_When_RequestIsInvalid() 
{
    var invalidRequest = //...
    var validator = new TerminationRequestValidation(/*...*/); // don't mock this class

    var result = validator.TerminationRequestValidation(invalidRequest);

    Assert.NotEqual(ValidationResult.Success, result);
}

As a general rule of thumb, avoid verifying how the method works internally. You're coupling your tests to implementation details and refactoring/maintaining those details will be a living hell.