C＃数据结构-引用调用对象属性的最佳方法是什么？

Question

My data is currently structured as follows:

class A
{
    B[] bArray;
    C[] cArray;

    A()
    {
        fillB();
        fillC();
    }
}
class C
{
    X[] x;

    insertX() // adds an X element to the x array
    {
        X newX = new X();
        newX.b = findB(searchParam); // returns the matching element from bArray
        // the rest of the code adds newX to array x
    }
}
class X
{
    B b {get;set;} // reference to an element bArray
}

This is how the data is currently structured. The problem I'm having is I'm not sure

1. If I'm structuring this properly
2. Where to place the findB function. The findB function was originally in class A, but class A is the calling object.

Any help would be greatly appreciated. I am new to asking questions about code, so bear with me please.

Answer 1

Objects that are being composed/aggregated usually do not know about their parents. So no, I wouldn't say your structure is very good.

That is, in your example, C has no idea that it is being created by A and so doesn't know anything about bArray . Depending on the context, this is exactly how it should be .

Now, you could pass an A reference to C :

class C
{
    A parent;
    X[] x;

    public C(A parent)
    {
        this.parent = parent;
    }

    insertX() // adds an X element to the x array
    {
        X newX = new X();
        newX.b = parent.findB(searchParam); // returns the matching element from bArray
        // the rest of the code adds newX to array x
    }
}

And put findB in A again. Thats where it should go, since its the only thing that knows about bArray .

But that tighlty couples C to A . That might be ok in your situation, it might not. In general though, tight coupling like that is to be avoided. Without better class names/context, its impossible to say what a better design would be in your situation.