提交表单后发送电子邮件

Question

I am working on a script for a simple mailing list signup on a splash page and I am having some issues sending a welcome/thanks email to the email address entered in the form.

My code: PHP

<?php
    if($_POST['formSubmit'] == "Submit")
    {    
        //email variables
        $subject = "Indie Rally - Welcome & Thanks!";
        $email_message = "Welcome and thanks for joining the Indie Rally Mailing List!\n\n";
        $email_message .= "Your Email: ".clean_string($first_name)." ";
        $email_message .= "Has been added to our mailing list and will be used to give development, site feature updates, and news.\n\n";
        $email_message .= "If at any point you have feedback, ideas, suggestions for features of Indie Rally, feel free to email us any time at admin@indierally.com\n";

        // create email headers
        $headers = 'From: admin@indierally.com' . "\r\n" .
                    'Reply-To: admin@indierally.com' . "\r\n" .
                    'X-Mailer: PHP/' . phpversion(); 

        //Database Connection
        mysql_connect ("localhost", "USERNAME", "PASS") or die ('Error: ' . mysql_error());
        mysql_select_db("DBNAME") or die ('Data error:' . mysql_error());

        $email = PrepSQL($_POST['formEmail']); 
        $query = "INSERT INTO mailinglist (email) VALUES (". $email . ")";

        mysql_query($query) or die ('Error updating database' . mysql_error());
        //success - email & forward
        mail($email, $subject, $email_message, $headers); 
        header("Location: submitted.html");
    }

    // function: PrepSQL()
    // use stripslashes and mysql_real_escape_string PHP functions
    // to sanitize a string for use in an SQL query
    //
    // also puts single quotes around the string
    //
    function PrepSQL($value)
    {
        // Stripslashes
        if(get_magic_quotes_gpc()) 
        {
            $value = stripslashes($value);
        }

        // Quote
        $value = "'" . mysql_real_escape_string($value) . "'";

        return($value);
    }
    function clean_string($string) {

      $bad = array("content-type","bcc:","to:","cc:","href");

      return str_replace($bad,"",$string);

    }
?>

My Code: the form

    <div class="maillist">
            <?php
                    if(!empty($errorMessage)) 
                    {
                            echo("<p>There was an error with your form:</p>\n");
                            echo("<ul>" . $errorMessage . "</ul>\n");
                    }
            ?>
            <form action="<?php echo htmlentities($_SERVER['PHP_SELF']); ?>" method="post">
                    <p>
                    <input type="text" name="formEmail" maxlength="50" value="<?=$varEmail;?>" placeholder="Email Me Updates!" />
                    <input type="submit" name="formSubmit" value="Submit" />
                    </p>
            </form>
    </div>

When I submit an email address, it submits to the database, however the email is never sent to the recipient.

See http://www.indierally.com to see exactly what I am talking about

Answer 1

Your $to variable isn't getting set thus PHP doesn't know where to send the email. If you changed your code to be:

if( !mail($to, $subject, $email_message, $headers) ) {
    echo 'error here...';
} else {
    header("Location: submitted.html");
}

You would see the failed message. Perhaps you should replace $to with $email ?