安全地删除析构函数中的内存

Question

I have the following code:

CCOLFile *pCOLFile = CCOLManager::getInstance()->parseFile(strCOLPath);
// ...
pCOLFile->unload();
delete pCOLFile;

Memory is allocated by the parseFile() function and stored in a std::vector in the pCOLFile object. Can I move my code from the unload() method to the CCOLFile destructor to safely delete the allocated memory?

I'm guessing destructors maybe were even designed for this?

The goal is to iterate around a std::vector and use delete on each value.

Here's my CCOLFile struct:

struct CCOLFile
{
    std::string                     m_strFilePath;
    std::vector<CCOLEntry*>         m_vecEntries;
};

And here's the current unload() method:

void                CCOLFile::unload(void)
{
    for (auto pCOLEntry : m_vecEntries)
    {
        delete pCOLEntry;
    }
    m_vecEntries.clear();
}

Answer 1

If you declare std::vector<std::unique_ptr<CColEntry>> m_vecEntries then you don't need an unload method; instead, in the destructor, just do delete m_vecEntries . The vector will clear its entries, and because they are unique_ptr 's, they will delete themselves.

Thus unload() is reduced to one line in the destructor.