使用jdbcTemplate和DAO层在jUnit中测试删除方法

Question

i'm trying to test my delete method but i don't know how can i do that, i tried inside my test delete method to invoke my searchByID with the id of the User i deleted to create a null variable and then use assertNull

like this:

    @Test
    public void deleteUser() 
    {

        userDAO.deleteUserById(3);
        User nullUser  =  userDAO.searchUserById(3);
        assertNull(nullUser);
    }

but this give me this error:

expected null but was domain.User@c506pb

i tried to use the exception approach, since i can whatch in my output that that code generates a java.sql.SQLException: ORA-01403: no data found i tried like this :

    @Test(expected=SQLException.class)
    public void deleteUser() 
    {

         userDAO.deleteUserById(3);
        Usuario usuarioVacio  =  usuarioDAO.buscarUsuarioPorId(3);

    }

but this give me this error:

Expected exception: java.sql.SQLException
java.lang.AssertionError

here is my delete method implementation

@Override
public void deleteUserById(int idUser)
{

    Connection connection = null;
    try {

        String storedProcedure =  "{ call deleteUserById(?) }";

        connection  =  jdbcTemplate.getDataSource().getConnection();
        CallableStatement callableStatement = connection.prepareCall(storedProcedureBorrarUSuario);

        callableStatement.setInt(1, idUser);

        callableStatement.executeQuery();
    } 
    catch (SQLException ex) 
    {

        ex.printStackTrace();
    }
    finally 
    {
        if(connection != null)
        try 
        {
            connection.close();
        } 
        catch (SQLException e) 
        {
            e.printStackTrace();
        }
    }
}

the method works since it deletes the correct user, i will like to do it using both approachs the exception approach and the other one, but i dont know why is not working

EDIT:

here is my searchById method

@Override
    public Usuario buscarUsuarioPorId(int userId) 
    {
        User user=  new  User();
        Connection connection = null;
        try {
            String storedProcedureInfoUsuario  =  "{ call searchUserById(?, ?, ?, ?, ?) }";

            connection  =  jdbcTemplate.getDataSource().getConnection();
            CallableStatement callableStatement = connection.prepareCall(storedProcedureInfoUsuario);

            callableStatement.setInt(1, idUsuario);
            callableStatement.registerOutParameter(2, Types.VARCHAR);
            callableStatement.registerOutParameter(3, Types.VARCHAR);
            callableStatement.registerOutParameter(4, Types.VARCHAR);
            callableStatement.registerOutParameter(5, Types.VARCHAR);

            callableStatement.executeQuery();

            //
            user.setName(callableStatement.getString(2));
            user.setLastName(callableStatement.getString(3));
            user.setEmail(callableStatement.getString(4));
            user.setState(callableStatement.getString(5));
        } 
        catch (SQLException ex) 
        {
//          Logger.getLogger(UsuarioDAOImplementacion.class.getName()).log(Level.SEVERE, null, ex);
            ex.printStackTrace();
        }
        finally 
        {
            if(connection != null)
            try 
            {
                connection.close();
            } 
            catch (SQLException e) 
            {
                e.printStackTrace();
            }
        }
        return usuario;
    }

and here is my PL/SQL searchById

CREATE OR REPLACE PROCEDURE searchUserById
    (
       p_userId IN User.user_id%TYPE,
       ps_name OUT User.name%TYPE,
       ps_lastName OUT User.lastName%TYPE,
       ps_email OUT User.email%TYPE,
       ps_state OUT User.state%TYPE
    )
IS
BEGIN

  SELECT name, lastName, email, state
  INTO ps_name , ps_lastName , ps_email , ps_state 
  FROM  USER WHERE user_id= p_userid;

END;
/

and here is my delete PL/SQL

CREATE OR REPLACE PROCEDURE deleteUserById
    (
       p_userId IN USER.user_ID%TYPE
    )
IS
BEGIN

  DELETE FROM USER
  WHERE user_id=p_userId;
COMMIT;
END;
/

EDIT 2

i created this suggested method but it gives me a error that i'm missing a return value so i added return null

 @Override
public void deleteUserById(final int idUser) {

    final String storedProcedureBorrarUSuario =  "{ call borrarUsuarioPorId(?) }";
    final Connection connection = null;

    jdbcTemplate.execute( new ConnectionCallback<Object>() 
    {
        @Override
        public Object doInConnection(Connection con) throws SQLException, DataAccessException 
        {
            CallableStatement callableStatement = connection.prepareCall(storedProcedureBorrarUSuario);
            callableStatement.setInt(1, idUser);
            callableStatement.executeUpdate();
            return null;

        }
    });   
}

and when i run my unit test it says null pointer exception in this line

userDAO.deleteUserById(3);

EDIT 3

i tried with this seting firts the user as null so if there's a exception my method returns a null object but still i have the same problem in my unit test when i try to use the exception approach

@Override
public Usuario searchUserById(int userId) 
{
    User user=  null;
    Connection connection = null;

    try {
        String storedProcedureInfoUsuario  =  "{ call searchUserById(?, ?, ?, ?, ?) }";

        connection  =  jdbcTemplate.getDataSource().getConnection();
        CallableStatement callableStatement = connection.prepareCall(storedProcedureInfoUsuario);

        callableStatement.setInt(1, userId);
        callableStatement.registerOutParameter(2, Types.VARCHAR);
        callableStatement.registerOutParameter(3, Types.VARCHAR);
        callableStatement.registerOutParameter(4, Types.VARCHAR);
        callableStatement.registerOutParameter(5, Types.VARCHAR);

        callableStatement.executeQuery();

        //
        user=  new User();
        usuario.setName(callableStatement.getString(2));
        usuario.setLastName(callableStatement.getString(3));
        usuario.setEmail(callableStatement.getString(4));
        usuario.setState(callableStatement.getString(5));
    } 
    catch (SQLException ex) 
    {
//          Logger.getLogger(UsuarioDAOImplementacion.class.getName()).log(Level.SEVERE, null, ex);
            ex.printStackTrace();
        }
        finally 
        {
            if(connection != null)
            try 
            {
                connection.close();
            } 
            catch (SQLException e) 
            {
                e.printStackTrace();
            }
        }
        return user;
    }

here is my unit test that i expect to have a null value this works with the modfications i did

public void findUserById()
{
    User emptyUser=  userDAO.searchUserById(50);
    assertNull(emptyUser);
}

but instead if i try to use the exception approach i have the following error

@Test(expected=SQLException.class) 
public void findUserById()
    {
        User emptyUser=  userDAO.searchUserById(50);
        assertNull(emptyUser);
    }

this give me Expected exception: java.sql.SQLException java.lang.AssertionError

i dont know why this not work if i have the following exception in my output java.sql.SQLException: ORA-01403: no data found

Answer 1

The problem lies in your method serachUserById(). I fixed it for you in the code bellow. You always returned a user object. No matter if there was a user in the database or not. The code bellow first assigns null to the user. I guess there is an exception if there is no user with this userId. So you catch the exception and continue returning null. If there is a user in the DB you will create a User object, fill it with values and return that one.

The key point is to distinguish between 1. There is a user and I return it with a User object and 2. There is not user and I return null.

@Override
public User serachUserById(int userId) 
{
    User user = null;
    Connection connection = null;
    try {
        String storedProcedureInfoUsuario  =  "{ call searchUserById(?, ?, ?, ?, ?) }";

        connection  =  jdbcTemplate.getDataSource().getConnection();
        CallableStatement callableStatement = connection.prepareCall(storedProcedureInfoUsuario);

        callableStatement.setInt(1, userId);
        callableStatement.registerOutParameter(2, Types.VARCHAR);
        callableStatement.registerOutParameter(3, Types.VARCHAR);
        callableStatement.registerOutParameter(4, Types.VARCHAR);
        callableStatement.registerOutParameter(5, Types.VARCHAR);

        callableStatement.executeQuery();

        //
        user = new User();
        user.setName(callableStatement.getString(2));
        user.setLastName(callableStatement.getString(3));
        user.setEmail(callableStatement.getString(4));
        user.setState(callableStatement.getString(5));
    } 
    catch (SQLException ex) 
    {

Logger.getLogger(UsuarioDAOImplementacion.class.getName()).log(Level.SEVERE, null, ex);
        ex.printStackTrace();
    }
    finally 
    {
        if(connection != null)
        try 
        {
            connection.close();
        } 
        catch (SQLException e) 
        {
            e.printStackTrace();
        }
    }
    return user;
}

Anyway I would recommend you to work with spring jpa repositories instead of jdbc connections, SQL and stored procedures. You will save a lot of time and bugs.

Answer 2

There could be below possibilities

1. There is problem within your PL/SQL. See when you are getting that exception? While deleting user or while searching the user.

2. What's the configuration value set for defaultRollback in your transaction configuration of the test context? If it is true that means your changes are getting rolled back after execution of test method and that's why you might be getting value in search user

3. If everything else is all-right then there might be issue with transaction boundaries.

Answer 3

For starters I would suggest you rewrite your JDBC code and actually use the JdbcTemplate . Instead of managing connections yourself, wrap your logic in a ConnectionCallback saves you from opening/closing a connection.

Second for modifications you should use executeUpdate ins

@Override
public void deleteUserById(final int idUser) {
    final String storedProcedure =  "{ call deleteUserById(?) }";
    getJdbcTemplate().execute(new ConnectionCallback<Object>() {
        public Object doInConnection(Connection con) throws SQLException, DataAccessException {
            CallableStatement callableStatement = con.prepareCall(storedProcedureBorrarUSuario);
            callableStatement.setInt(1, idUser);
            callableStatement.executeUpdate();
            return null;
        }
    });   
}

@Override
public Usuario buscarUsuarioPorId(final int userId) {       
    User user=  new  User();
    final String storedProcedureInfoUsuario  =  "{ call searchUserById(?, ?, ?, ?, ?) }";
    return getJdbcTemplate().execute(new ConnectionCallback<User>() {
        public User doInConnection(Connection con) throws SQLException, DataAccessException {
        CallableStatement callableStatement = con.prepareCall(storedProcedureInfoUsuario);

        callableStatement.setInt(1, idUsuario);
        callableStatement.registerOutParameter(2, Types.VARCHAR);
        callableStatement.registerOutParameter(3, Types.VARCHAR);
        callableStatement.registerOutParameter(4, Types.VARCHAR);
        callableStatement.registerOutParameter(5, Types.VARCHAR);

        callableStatement.executeQuery();
        //
        user.setName(callableStatement.getString(2));
        user.setLastName(callableStatement.getString(3));
        user.setEmail(callableStatement.getString(4));
        user.setState(callableStatement.getString(5));

    });
}