C ++ 2d数组运行时错误

Question

doing some assignment, here's a function to count negative numbers in a dynamically allocated 2D array:

 void numberOfNegs(int** arrayPointer, int n) {
    int counter{ 0 };
    for (int i{ 0 }; i < n; i++){
        for (int j{ 0 }; j < n; j++){
            if (arrayPointer[i][j] < 0) {
                counter++;
            }
        }
    }

Seems legit to me, but the debugger throws this error:

Unhandled exception at 0x00C25D9A in *.exe: 0xC0000005: Access violation reading location 0xCDCDCDCD.

Please, help

Here's more code on how I casted it

    std::cin >> x;

int** theMatrix = new int*[x];
for (int i{ 0 }; i < x; i++){
    theMatrix[x] = new int[x];
}

std::cout << "Please enter a matrix " << x << std::endl;

for (int i{ 0 }; i < x; i++) {
    for (int j{ 0 }; j < x; j++) {
        std::cin >> theMatrix[x][x];
    }
}

 numberOfNegs(theMatrix, x)

Answer 1

Your initialisation problem is here:

for (int i{ 0 }; i < x; i++){
    theMatrix[x] = new int[x];
}

You are using x as the array index, while your (probably) mean i . Your current code just creates an array for the last element, x times. Change it to:

for (int i{ 0 }; i < x; i++){
    theMatrix[i] = new int[x];
}

You may also want to adjust this code:

for (int i{ 0 }; i < x; i++) {
    for (int j{ 0 }; j < x; j++) {
        std::cin >> theMatrix[x][x];
    }
}

To:

for (int i{ 0 }; i < x; i++) {
    for (int j{ 0 }; j < x; j++) {
        std::cin >> theMatrix[i][j];
    }
}