如何从CFFUNCTION传递JSON

Question

I am new to JSON, in fact Javascript. I actually found the code from someone and try to implement this for what I am trying to do.

On my javascript I have:

function signin(var1,var2) {
Signin('login.htm?var1=' + var1 + '&var2=' + var2);
}

function skypeme(var1, var2) {
    $.ajax({
        url: "skypeme.cfc",
        dataType: "json",
        data: {a:var1, b:var2},
        success: function(userData) {
            if(userData.LOGIN == 'true' && userData.ID!='') {
                window.location = 'skype:'+userData.ID+'?chat'; 
            }
            else {
                signin(var1,var2);
            }
        }
    });
}

And on my skypeme.cfc:

<cfcomponent output="false"> 
<cffunction name="cfskypeme" access="remote" returnformat="JSON" output="false"> 
<cfargument name="a" required="true"> 
<cfargument name="b" required="true">  
<cfset var stReturn = structNew()>
<cfset stReturn.LOGIN=false>
<cfset stReturn.ID="">

if user login
    check database for skypeid
        <cfif skypelist.recordcount eq 1>
           <cfset stReturn.LOGIN=true>
           <cfset stReturn.ID=skypelist.skype>
        </cfif>
        <cfreturn SerializeJSON(stReturn)>
if user not login
    <cfreturn SerializeJSON(stReturn)>

</cffunction> 

</cfcomponent>

What I want to do is call the cfc and check if user is login, if not call the signin function. If the user is already signed in, check the database. If skype id is found, kick up skype, if not do nothing. But what is happening is when I called the skypme() function from my html, nothing happen. No error but skype doesn't start.

What is the right way of passing the JSON value from cffunction so that it can be executed on the javasctipt side? I have tried many ways but just can't get it to work. Please help. Thank you.

Answer 1

A couple of issues: your the success portion of your ajax call will always execute if skypeme.cfc returns 200 OK (html header), so returning "false" will actually return the string "false", and success will execute. What you should do is always return a JSON string, and have the format be always the same (also why are you using a query object? use a structure):

<cfcomponent output="false"> 
    <cffunction name="cfskypeme" access="remote" returnformat="JSON" output="false"> 
        <cfargument name="var1" required="true"> 
        <cfargument name="var2" required="true">  
        <cfset var stReturn = structNew()>
        <cfset stReturn.LOGIN=false>
        <cfset stReturn.ID="">

            <cfif user login logic>
                <cfquery name="skypelist"> <!---check db for skypeid--->
                </cfquery>
                <cfif skypelist.recordcount eq 1>
                    <cfset stReturn.LOGIN=true>
                    <cfset stReturn.ID=skypelist.skype>
                </cfif>
            </cfif> <!--- end login logic --->

        <cfreturn SerializeJSON(stReturn)>
    </cffunction> 
</cfcomponent>