从列表中删除计时器 <Timer> 在运行时C＃

Question

I'm trying to remove a Timer component from a List -

foreach (Timer timer in timers)
{
    if (timer.Tag.ToString()=="mytag")
    {
        timer.Enabled = false;

        timer.Tick -= OnTimerTick;
        timers.Remove(timer);
    }
}

But it gives error-

Collection was modified; enumeration operation may not execute.

Any help?

Answer 1

For unknown size you should use a list instead of an array.

Try List<Timer> timers = new List<Timer>();

[Edit] You just changed the whole question to a new one after this answer. You can't remove an item inside a foreach loop. You could use a duplicate for that list or simply iterate backwards:

for (int i = timers.Count - 1; i >= 0; i--)
{
    if (timers[i].Tag.ToString()=="mytag")
    {
        timers[i].Enabled = false;
        timers[i].Tick -= OnTimerTick;
        timers.RemoveAt(i);
    }
}

Answer 2

You can't modify a collection in a foreach like that in C#. You can work around this by changing:

 foreach (Timer timer in timers)
    {
        if (timer.Tag.ToString()=="mytag")
        {
            timer.Enabled = false;

            timer.Tick -= OnTimerTick;
            timers.Remove(timer);
        }
    }

To this instead:

var timersToRemove = new List<Timer>();
foreach (Timer timer in timers)
    {
        if (timer.Tag.ToString()=="mytag")
        {
            timer.Enabled = false;

            timer.Tick -= OnTimerTick;
            timersToRemove.Add(timer);
        }
    }

foreach(var timer in timersToRemove)
   timers.Remove(timer);
// Clear the list
timersToRemove.Clear();