消毒destroy_all的最佳方法是什么-Rails

Question

I have the following controller in Rails :

class FooController < ApplicationController
    def delete_foo(bar):
        Foo.destroy_all("foo = '#{@bar}'")

Is

Foo.destroy_all("foo = ?", @bar)

always valid?

Answer 1

destroy_all works on a relation. Why not do

 Foo.where(foo: bar).destroy_all

Answer 2

Foo.destroy_all("foo = ?", @bar) , This is invalid.

From apidoc , we will find:

destroy_all(conditions = nil) public

destroy_all method only accepts a single argument, the argument can be a string, array, or hash. You cannot pass two arguments.

So you can write like this:

Foo.destroy_all("foo = #{@bar}")
Foo.destroy_all(foo: @bar)
Foo.where(foo: @bar).destroy_all