通过向右滑动从自定义RecycleView适配器中删除项目会弄乱项目的顺序

Question

I have an ArrayList <String> with 6 items {"1", "2", "3", "4", "5", "6"}.

I am representing these items with a CardView . I want to remove the items with swiping left.

It looks like this: http://imgur.com/cuWoiB3

When I swipe right from number 2, it looks like this: http://imgur.com/5E9fwP0

If I remove Number 5, it removes number 2. If I remove number 3, it removes number 1. It seems to be completely random.

Am I missing something here? How do I fix this?

Relevant code:

My adapter:

public class ChoresAdapter extends RecyclerView.Adapter<ChoresAdapter.ChoreViewHolder>{

private ArrayList<String> chores;

public ChoresAdapter(ArrayList<String> chores){
    this.chores = chores;
}

@Override
public ChoreViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
    View v = LayoutInflater.from(parent.getContext()).inflate(R.layout.single_cardview, parent, false);
    v.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {

        }
    });
    ChoreViewHolder pvh = new ChoreViewHolder(v);
    return pvh;
}


@Override
public void onBindViewHolder(ChoreViewHolder holder, int position) {
    holder.choreName.setText(this.chores.get(position));
}

@Override
public int getItemCount() {
    return this.chores.size();
}

public void removeAt(int position) {
    this.chores.remove(position);
    notifyItemRemoved(position);
    notifyDataSetChanged();
}

public static class ChoreViewHolder extends RecyclerView.ViewHolder {
    CardView cv;
    public static TextView choreName;
    public static TextView personAge;
    public static ImageView personPhoto;

    ChoreViewHolder(View itemView) {
        super(itemView);
        cv = (CardView)itemView.findViewById(R.id.cv);
        choreName = (TextView)itemView.findViewById(R.id.chore_name);
    }
    }

  }

Relevant code in my fragment:

    @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {
    View view = inflater.inflate(R.layout.fragment_chores, container, false);
    RecyclerView rv = (RecyclerView)view.findViewById(R.id.rv);
    rv.setHasFixedSize(true);

    LinearLayoutManager llm = new LinearLayoutManager(getActivity());
    rv.setLayoutManager(llm);
    chores = new ArrayList<>();
    chores.add("1");
    chores.add("2");
    chores.add("3");
    chores.add("4");
    chores.add("5");
    chores.add("6");
    adapter = new ChoresAdapter(chores);
    SwipeableRecyclerViewTouchListener swipeTouchListener =
            new SwipeableRecyclerViewTouchListener(rv,
                    new SwipeableRecyclerViewTouchListener.SwipeListener() {
                        @Override
                        public boolean canSwipe(int position) {
                            return true;
                        }

                        @Override
                        public void onDismissedBySwipeLeft(RecyclerView recyclerView, int[] reverseSortedPositions) {
                            for (int position : reverseSortedPositions) {
                                adapter.removeAt(position);
                            }
                        }

                        @Override
                        public void onDismissedBySwipeRight(RecyclerView recyclerView, int[] reverseSortedPositions) {
                            for (int position : reverseSortedPositions) {
                                adapter.removeAt(position);
                            }
                        }
                    });

    rv.addOnItemTouchListener(swipeTouchListener);
    rv.setAdapter(adapter);
    return view;
}

Answer 1

Its bit late, I just fall into the same situation and got answer, Just use

chores.remove(position);
adapter.notifyDataSetChanged();

You dont need to do that on the adapter class.

Answer 2

You can use below code ( ItemTouchHelper.SimpleCallback from Android support V7) to remove the cards from RecyclerView using swipe gesture. You need to remove element from your ArrayList as well when you swipe it from RecyclerView.

ItemTouchHelper.SimpleCallback simpleItemTouchCallback = new ItemTouchHelper.SimpleCallback(0, ItemTouchHelper.LEFT | ItemTouchHelper.RIGHT) {

    @Override
    public boolean onMove(RecyclerView recyclerView, RecyclerView.ViewHolder viewHolder, RecyclerView.ViewHolder target) {
        return false;
    }

    @Override
    public void onSwiped(RecyclerView.ViewHolder viewHolder, int swipeDir) {
        chores.remove(viewHolder.getAdapterPosition());
        adapter.notifyItemRemoved(viewHolder.getAdapterPosition());
    }

    @Override
    public void onMoved(RecyclerView recyclerView, RecyclerView.ViewHolder viewHolder, int fromPos, RecyclerView.ViewHolder target, int toPos, int x, int y) {
        super.onMoved(recyclerView, viewHolder, fromPos, target, toPos, x, y);
    }
};

ItemTouchHelper itemTouchHelper = new ItemTouchHelper(simpleItemTouchCallback);
itemTouchHelper.attachToRecyclerView(recList);