如何在C＃中将值连接成逗号分隔的值

Question

I am reading text file where I would like to get values based on condition. First I will take FREQ where CELLID = 639 and ISMAINBCCH=YES,that I have done now next task is I have to concatenate FREQ values in a comma separated way where CELLID=639 and ISMAINBCCH=NO, so the output I want is 24,28,67. How to achieve that?

lines are

ADD GCELL:CELLID=639, CELLNAME="NR_0702_07021_G1_A", MCC="424", MNC="02", LAC=6112, CI=7021, NCC=6, BCC=0, EXTTP=Normal_cell, IUOTP=Concentric_cell, ENIUO=ON, DBFREQBCCHIUO=Extra, FLEXMAIO=OFF, CSVSP=3, CSDSP=5, PSHPSP=4, PSLPSVP=6, BSPBCCHBLKS=1, BSPAGBLKSRES=4, BSPRACHBLKS=1, TYPE=GSM900_DCS1800, 
......................
.............

ADD GTRX:TRXID=0, TRXNAME="M_RAK_JeerExch_G_1879_18791_A-0", FREQ=81, TRXNO=0, CELLID=639, IDTYPE=BYID, ISMAINBCCH=YES, ISTMPTRX=NO, GTRXGROUPID=2556;
ADD GTRX:TRXID=1, TRXNAME="M_RAK_JeerExch_G_1879_18791_A-1", FREQ=24, TRXNO=1, CELLID=639, IDTYPE=BYID, ISMAINBCCH=NO, ISTMPTRX=NO, GTRXGROUPID=2556;
ADD GTRX:TRXID=5, TRXNAME="M_RAK_JeerExch_G_1879_18791_A-2", FREQ=28, TRXNO=2, CELLID=639, IDTYPE=BYID, ISMAINBCCH=NO, ISTMPTRX=NO, GTRXGROUPID=2556;
ADD GTRX:TRXID=6, TRXNAME="M_RAK_JeerExch_G_1879_18791_A-3", FREQ=67, TRXNO=3, CELLID=639, IDTYPE=BYID, ISMAINBCCH=NO, ISTMPTRX=NO, GTRXGROUPID=2556;

Update

I am getting values like shown below

using (StreamReader sr = File.OpenText(filename))
{
    while ((s = sr.ReadLine()) != null)
    {
        if (s.Contains("ADD GCELL:"))
        {
            var gtrx = new Gtrx
            {
                CellId = int.Parse(PullValue(s, "CELLID")),
                Freq = int.Parse(PullValue(s, "FREQ")),
                TrxNo = int.Parse(PullValue(s, "TRXNO")),
                IsMainBcch = PullValue(s, "ISMAINBCCH").ToUpper() == "YES",
                TrxName = PullValue(s, "TRXNAME"),

            };

        }
    }

UPDATE

I used facade concept, but now it is taking lot of time. I am not sure whether I am using any bad logic two times I am iterating text file one for getting regular values and other for getting concatenated values

 private class Gtrx
    {
        public int Freq { get; set; }
        public int TrxNo { get; set; }
        public string TrxName { get; set; }
        public int CellId { get; set; }
        public bool IsMainBcch { get; set; }
    }

    private class Gcell
    {
        public int CellId { get; set; }
        public string CellName { get; set; }
        public string Mcc { get; set; }
        public int Lac { get; set; }
        public int Ci { get; set; }
    }
    private class GcellGtrx
    {
        public Gcell Gcell { get; set; }
        public Gtrx Gtrx { get; set; }
    }

using (var sr = new StringReader(data))
{
    string line = sr.ReadLine();
    while (line != null)
    {
        line = line.Trim();
        if (line.StartsWith("ADD GCELL:"))
        {
            var gcell = new Gcell
            {
                CellId = int.Parse(PullValue(line, "CELLID")),
                CellName = PullValue(line, "CELLNAME"),
                Ci = int.Parse(PullValue(line, "CI")),
                Lac = int.Parse(PullValue(line, "LAC")),
                Mcc = PullValue(line, "MCC")
            };
            var gcellGtrx = new GcellGtrx();
            gcellGtrx.Gcell = gcell;
            _dictionary.Add(gcell.CellId, gcellGtrx);
        }
        if (line.StartsWith("ADD GTRX:"))
        {
            var gtrx = new Gtrx
            {
                CellId = int.Parse(PullValue(line, "CELLID")),
                Freq = int.Parse(PullValue(line, "FREQ")),
                TrxNo = int.Parse(PullValue(line, "TRXNO")),
                IsMainBcch = PullValue(line, "ISMAINBCCH").ToUpper() == "YES",
DEFINED_TCH_FRQ = null,
                TrxName = PullValue(line, "TRXNAME")
            };

           if (!intarr.Contains(gtrx.CellId))
                            {

                                if (!_dictionary.ContainsKey(gtrx.CellId))
                                {
                                    // No GCell record for this id. Do something!
                                    continue;
                                }
                                intarr.Add(gtrx.CellId);
                                string results = string.Empty;

                                    var result = String.Join(",",
        from ss in File.ReadLines(filename)
        where ss.Contains("ADD GTRX:")
        where int.Parse(PullValue(ss, "CELLID")) == gtrx.CellId
        where PullValue(ss, "ISMAINBCCH").ToUpper() != "YES"
        select int.Parse(PullValue(ss, "FREQ")));
                                    results = result;


                                var gtrxnew = new Gtrx
                                {
                                    DEFINED_TCH_FRQ = results
                                };

                                _dictionary[gtrx.CellId].Gtrx = gtrx;
        }
        line = sr.ReadLine();
    }
}

UPDATE

Finally I did it like first I saved lines starting with ADD GTRX in to an array by using File. Readalllines and then used only that array to get concatenated string instead of storing entire text file and got some performance improvement.

If I convert my Text files that contain hundreds of thousands of lines each into xml and then retrieve data from xml file rather from text file, will it make any performance improvement? If I use datatable and dataset rather than classes here will be a performance improvement?

Answer 1

Create gtrxs collection to store Gtrx objects and read data from file in to gtrxs . Then you can use LINQ (ming need to add using System.Linq; ) to find Gtrx objects that are matching your requirements and call Select to get list of Freq values. Once you have a list, you can simply use String.Join(",", freqValues) to build up CSV string.

var gtrxs = new List<Gtrx>();

using (StreamReader sr = File.OpenText(filename))
{
    while ((s = sr.ReadLine()) != null)
    {


        if (s.Contains("ADD GCELL:"))
        {

            var gtrx = new Gtrx
                                {
                                    CellId = int.Parse(PullValue(s, "CELLID")),
                                    Freq = int.Parse(PullValue(s, "FREQ")),
                                    TrxNo = int.Parse(PullValue(s, "TRXNO")),
                                    IsMainBcch = PullValue(s, "ISMAINBCCH").ToUpper() == "YES",
                                    TrxName = PullValue(s, "TRXNAME"),

                                };

            gtrxs.Add(gtrx);
        }
    }
}

IEnumerable<int> freqValues = gtrxs.Where(x => x.CellId == 639 && x.IsMainBcch == false).Select(x => x.Freq);
string result = String.Join(",", freqValues);

Answer 2

Does this work for you?

var result = String.Join(",", 
    from s in File.ReadAllLines(filename)
    where s.Contains("ADD GCELL:")
    where int.Parse(PullValue(s, "CELLID")) == 639
    where PullValue(s, "ISMAINBCCH").ToUpper() != "YES"
    select int.Parse(PullValue(s, "FREQ")));