减少if语句本身

Question

This is my if-statement at the moment:

   if (excel_getValue("A" + i) == "" && 
    excel_getValue("A" + (i + 1)) == "" && 
    excel_getValue("A" + (i + 2)) == "" && 
    excel_getValue("A" + (i + 3)) == "" && 
    excel_getValue("A" + (i + 4)) == "" && 
    excel_getValue("A" + (i + 5)) == "" && 
    excel_getValue("A" + (i + 6)) == "" && 
    excel_getValue("A" + (i + 7)) == "" && 
    excel_getValue("A" + (i + 8)) == "")

Is there anyway I can reduce this statement? Should I build this if-statement in a for-loop?

BTW, this if-statement if already in a forloop and it uses the i of the forloop

Answer 1

You can use All :

if(Enumerable.Range(0, 9).All(c => excel_getValue("A" + (i + c)) == "")) {
}

Answer 2

There's an easy way to "reduce" (at least "beautify") with a for loop... this wouldn't be more performant though, so you choose:

bool do = true;
for(var j = 0; j < 9; j++) { 
   if (excel_getValue("A" + (i+j)) != "") {
     do = false;
     break;
   }
}
if(do) { /* whatever */ }

Or using Linq:

if(Enumerable.Range(0, 9).All(x => excel_getValue("A" + (i + x)) == "")) { /* whatever */ }

This could be probably reduced easily, but I guess the point is that it should be "prettier", and not "better" or "complicated". Nothing would beat your original one in terms of performance :-)

Answer 3

Yes, a for loop is a good way to simplify your code in this case. Something like:

   bool result = true;
   for(int j = 0; j < max; j++)
   {
      result = result && excel_getValue("A" + (i + j)) == "";
   }

Answer 4

你可以尝试这样的事情：

if (Enumerable.Range(0, 8).All(p => excel_getValue("A" + (i + p)) == ""))