在else子句中停止阻止默认

Question

Hello I have a mobile nav where some items have a subnav so I have set a preventDefault to stop these doing there normal actions and open the sub menu but some don't have a submenu ad now these don't work as normal.

Any help would be great here is my code. Also this is a mobile only problem.

 $('.touch .mobile-list > li > a').on('click', function(e){
            e.preventDefault();
            if($(this).parents('li').hasClass('visible-submenu')) {
                $(this).parents('li').removeClass('visible-submenu');

            } else {
                 $('.mobile-list li.visible-submenu').removeClass('visible-submenu');
                 $(this).parents('li').addClass('visible-submenu');
            }

        });

Answer 1

Try moving e.preventDefault(); into the appropriate branch of the if statement

for example:

$('.touch .mobile-list > li > a').on('click', function(e){
        if($(this).parents('li').hasClass('visible-submenu')) {
            $(this).parents('li').removeClass('visible-submenu');
            e.preventDefault();
        } else {
             $('.mobile-list li.visible-submenu').removeClass('visible-submenu');
             $(this).parents('li').addClass('visible-submenu');
        }

    });