如何让我自己的号码与宾果游戏的随机数核对

Question

My bingo game should be very simple you write 10 numbers from 1 - 25 and it should take out 7 random numbers to compare with my own 10 numbers, and in the end I want it to show the result.

I got messed up with numbers == bingorow . How to make it check how many right I had? Here's my code:

static void Main(string[] args)
{
    int right = 0;
    bool foundNr = false;
    int[] bingorow = new int[11];
    for (int i = 0; i < bingorow.Length; i++)
    {
        try
        {
            Console.WriteLine("Welcome to C Sharp Bingo!");
            Console.Write("Write down 10 numbers here: ");
            int bingonr = int.Parse(Console.ReadLine());
            bingorow[i] = bingonr;
        }
        catch
        {
            Console.WriteLine("Please write 10 numbers!");
            continue;
        }

        int[] number = new int[7];
        Random randmNr = new Random();
        for (int r = 0; r < number.Length; r++)
        {
            number[r] = randmNr.Next(1, 25);
        }

        if (number == bingorow)
        {
            foundNr = true;
        }

        if (foundNr == true)
        {
            right++;
        }
        {
            Console.WriteLine("  Your score: {0} of 7", right);
            Console.ReadLine();
        }
    }
}

Answer 1

This is a sloppy answer, but it might help you with your problem.

First, your for loop will run 11 times regardless of whether the try/catch block fails.

int[] bingorow = new int[11];
for (int i = 0; i < bingorow.Length; i++)

Second, when you "continue" from the catch, you basically print a message and the program continues. I would advise to throw an appropriate exception.

Third, back to the for loop - the program will accept a value and then run all the code. So basically you would guess 1 out of 7 if you are lucky. Then the loop will run again for a second time and you would get another number... etc. This is why I've taken all the code after the catch outside the loop. That way it will iterate a number of times (in this case 7) and get a number from the input on each iteration. After all 7 numbers have been stored, it will carry on with the rest of the code.

Fourth, not sure if you want the numbers to be in the range 1-25 inclusive.

number[r] = randmNr.Next(1, 25);

This will return numbers in the range 1-24 inclusive as the upper bound of the Next method is exclusive as Mark has stated here: https://stackoverflow.com/a/5063276/4453195

Here is a simple solution to your problem:

static void Main(string[] args)
{
    int right = 0;
    int[] bingorow = new int[7]; // Correct me if I'm wrong but I think a 7 number bingo should accept 7 numbers as input
    string[] positions = { "first", "second", "third", "fourth", "fifth", "sixth", "seventh" }; // This is not necessary, but makes the flow slightly clearer.

    Console.WriteLine("#########################");
    Console.WriteLine("Welcome to C Sharp Bingo!");
    Console.WriteLine("#########################");
    Console.WriteLine("Please provide your 7 numbers in the range from 1 to 25.");

    for (int i = 0; i < bingorow.Length; i++)
    {
        try
        {
            Console.WriteLine("Enter your {0} number:", positions[i]);
            int bingonr = int.Parse(Console.ReadLine());
            bingorow[i] = bingonr;
        }

        catch
        {
            Console.WriteLine("Some error message.");
            // Some Exception should be thrown here don't just use "continue".
            continue;
        }
    }

   int[] numbers = new int[7];
   Random randmNr = new Random();
   for (int r = 0; r < numbers.Length; r++)
   {
       // randmNr.Next(1, 26) will return numbers in the range 1-25 inclusive.
       numbers[r] = randmNr.Next(1, 26);
   }

   // Loop through each number from the input (bingorow) array and check if it is contained in the "winning" (numbers) array
   for (int i = 0; i < bingorow.Length; i++)
   {
       if (numbers.Contains(bingorow[i]))
       {
           right++; // Increment counter on each match.
       }
   }

   {
       Console.WriteLine();
       Console.WriteLine("### Your score: {0} of 7 ###", right);
       Console.Write("Your numbers:");

       // Print the input numbers.
       foreach (int number in bingorow)
       {
           Console.Write(" {0}", number); // Will not be sorted.
       }

       Console.WriteLine();

       Console.Write("Winning numbers:");

       // Print the winning numbers.
       foreach (int number in numbers)
       {
           Console.Write(" {0}", number); // Will not be sorted.
       }

       Console.WriteLine();

       Console.WriteLine("Press Enter to exit.");
       Console.ReadLine();
   }
}

Answer 2

You can't just compare two arrays via arr1 == arr2 . In c#, arrays are references to different objects.

int arr1[] = new int[] {1, 2, 3};
int arr2[] = new int[] {1, 2, 3};
if (arr1 == arr2) // Same as arr1.equals(arr2)
    Console.WriteLine("Same");
else
    Console.WriteLine("Not same"); //Will print not same.

.Net provides many different methods for comparing arrays and list structures. For .NET 4.0 and higher, Structural Comparisons can be used. Else a much simpler version would be to use:

int arr1[] = new int[] {1, 2, 3};
int arr2[] = new int[] {1, 2, 3};
Console.WriteLine(arr1.SequenceEqual(arr2)); //Done using Linq.

Change number == bingorow to number.SequenceEqual(bingorow) to check if the arrays themselves are equal. If you're looking for the individual elements that are correct, then you'll need to do a nested loop or some form of for loop that checks each individual value in the array.

Ex:

for( int i = 0; i < arr1.length; i++) //or whichever array is shorter
    if(arr1[i] == arr2[i])
       //true
    //else false