在量角器中正确使用页面对象模式

Question

I have an Angular app and I am using Protractor to test it.

HTML

 <div id="all" class="row text-center">
        <div class="col-lg-4 col-md-4 col-sm-6 col-xs-6">
          <div class="dashboard-stat block panel padder-v bg-primary">
            <div class="icon hidden-xs">
              <img src="../assets/images/icon-ppt-inv.png">
            </div>
            <div>
              <div id="value" class="font-thin h1 block">
                {{summary.num | number:0}}
              </div>
              <div id="name" class="text-muted text-xs">
                Albert
              </div>
            </div>
          </div>
        </div>
        </div>

Here is the code for the Page Object:

    'use strict';

        var history_page = function (){

            this.getStat = function(){
                return element.all(by.css('#all'));
            };

            this.getName = function(){
                return element(by.css('#name')).getText();
            };

            this.getValue = function(){
                return element(by.css('#value')).getText();
            };


        };

        module.exports = new history_page();

Test Code

 var historyPage = require('./history_page.js');

    it('Test', function(){


     var history = historyPage.getStat().map(function (stat) {
        return {
            name: stat.historyPage.getName()
            value: stat.historyPage.getValue(),
        }
    });

     history.then(function (value) {
        console.log(value);
    });


     });

For some reason I keep getting an error saying getName is not defined. If I change the following two lines

name: stat.historyPage.getName() 
value: stat.historyPage.getValue(),

as

name: stat.element(by.css('#name')).getText(),
value: stat.element(by.css('#value')).getText()

It works fine. I am not sure what the reason is. I really want to avoid writing css locators on my test page as it does not look good and it is a bad practice. I will appreciate suggestions to help me.

Answer 1

I would move the complete map() block into the Page Object:

var history_page = function () {
    this.all = element.all(by.css('#all'));

    this.getStat = function() {
        return this.all.map(function (stat) {
            return {
                name: stat.element(by.css('#name')).getText(),
                value: stat.element(by.css('#value')).getText()
            }
        });
    };
};

module.exports = new history_page();

Answer 2

'use strict';

    var history_page = function (){

        this.getStat = function(){
            return element.all(by.css('#all'));
        };

        this.getName = function(index){
            return this.getStat().then(function(stats){
                  return stats[index].get(index).element(by.css('#name'));
        };


    };

    module.exports = new history_page();

Answer 3

Yup, locators, functions (like @alecxe mentions), and conditions belong in the page object. Otherwise it defeats the purpose of them.

I would do something like:

var historyPage = function() {
    this.stats = $$('.row');
    this.name = $('#name');
    this.getValue = $('#value');
};
module.exports = new history_page();

And the test to be something like:

var historyPage = require('./history_page.js');

it('Test', function() {
    expect(historyPage.name.getText()).toBe('Albert');
});

Using a map for repeated data is cool... but in your example, I'm not sure I follow. #all would be unique, so if you're going to map repeated data, you'd probably want to map off of .row ? Not sure. But it might look something like this:

    this.getStat = function() {
        var that = this;
        return this.stats.map(function(stat) {
            return {
                // not tested... 
                name: stat.that.name.getText(),
                value: stat.that.value.getText()
            }
        });
    };

And FWIW, I have some page object examples in my protractor_example repo