for 循环创建对象数组会导致错误的值

Question

I am currently trying to create an array of objects out of a char Array. My problem is that somehow the for-loop seems to insert wrong values into the objects. And I just can't figure out what's going wrong. I was trying to fix it for hours but nothing worked.

For example: The if inside of the for loop detects it is at the right char '@' and j=6, k=5. (checked it with System.out.println().) I tell it to create an object inside for the GameObject array and give it the appropriate coordinates (x=k, y=j). But for some reason the coordinates turn out to be (k=)x=5 and (j=)y=5 instead?!

Both values always seem to be identical for some reason. No matter what, it's always 1,1; 2,2; 3,3 etc... The number is basically k (=the intended y-coordinate) taken twice. It seems to not access the "j" correctly?

The object array itself is all right, just the values inside of the objects turn out wrong.

In code, the method looks like this:

public static GameObject[][] initGO(int x, int y) throws IOException {

    GameObject[][] goMap = new GameObject[x][y];
    LoadFile loader = new LoadFile();
    char[] ch = loader.readChar("src\\control\\bla.txt");

    int i = 0;
    while (i < ch.length) {
        for (int j = 0; j < y; j++) {
            for (int k = 0; k < x; k++) {
                if (ch[i] == '@') {
                    goMap[k][j] = new Player(k, j, "Player");
                }
                i++;
            }
        }
    }
    return goMap;
}

Player just looks like this:

public class Player extends GameObject {

    public Player(int x, int y, String name) {
        super(x, y, name);
        this.x=y;
        this.y=y;
        this.name = name;
    }
}

Thanks a lot for anyone trying to help!

Answer 1

You made a simple copy-paste-edit error when setting variables. Look at this part of the code:

public Player(int x, int y, String name) {
    super(x, y, name);
    this.x=y; // <-- This should be "this.x=x;"
    this.y=y;
    this.name = name;
}