EXCEL VBA如果它们具有匹配的字符串，则从单独的工作簿中复制某些列

Question

So basically I'm currently working on a project that has over 300 entries, these 300 are pulled from a master workbook that has 1000+. They each have there own unique registration so what im looking for is vba that if the registration from the workbook with 300 entries can be found in the masterwork book to copy certain from the master into the smaller one. Had they all been in order I could of done this quite easily but due to them being in different orders I can't figure it out.

Here's what I have so far, what i'm trying to do is to use arrays, so that if an array value is found in the master it would copy, however it isn't working out for me :(..

Dim owb As Workbook
Dim test1(500) As String, test2(500) As String, test3(500) As String, test4  (500) As String 


With Application
.DisplayAlerts = False
.ScreenUpdating = False
.EnableEvents = False
End With

 fpath = "\Work\new location\mastercars.xlsx" 'file location
 Set owb = Application.Workbooks.Open(fpath) 'open file
For i = 1 To 500 'for each I 


    test1(i) = ThisWorkbook.Worksheets("Carlist").Cells(i, 1).Value
    test2(i) = ThisWorkbook.Worksheets("Carlist").Cells(i, 8).Value
    test3(i) = owb.Worksheets("Sheet2").Cells(i, 1).Value
    test4(i) = owb.Worksheets("Sheet2").Cells(i, 2).Value 'declare locations

    If test3(i) = test1(i) Then
        test2(i) = test4(i)
    End If
Next

Thanks

Answer 1

Since they are unordered, you need two loops for testing. You don't actually need an array, you can test the values directly from the cells, and you must set them to the cells (setting values into an array changes nothing on the sheet).

Dim Master as Worksheet
Dim Slave as Worksheet

'please verify if the master and slave are correct here
Set Master = owb.Worksheets("Sheet2")
Set Slave = ThisWorkbook.Worksheets("Carlist")

For i = 1 to 500 '(the slave sheet)
   For j = 1 to 5000 '(the master sheet)
       If Master.Cells(j,1).Value = Slave.Cells(i,1).Value then
           Slave.Cells(i,8).Value = Master.Cells(j,2).Value
       EndIf
   Next
Next

Never forget to turn screen updating back to true , or you will not be able to use Excel properly after that and you will not see your inserted data properly.

You don't need to disable alerts and events, they will make no difference. Screen updating can make your code slow, so it's useful to disable it.

Answer 2

Daniel's answer is excellent, but could be a bit slow because of all the looping (passing 5000 rows in the Slave sheet 500 times). It's also limited to only searching for 500 rows in the Master sheet.

This approach will review each row in Master , looking for the matching data in Slave .

Option Explicit  'require variables to be defined before use - always a good idea

Sub MySearch()
  On Error Goto CleanExit
  'Leave this line commented until everything is working as expected:
  'Application.ScreenUpdating = False
  'please verify if the master and slave are correct here
  Dim Master as Worksheet
  Set Master = owb.Worksheets("Sheet2")
  Dim Slave as Worksheet
  Set Slave = ThisWorkbook.Worksheets("Carlist")

  Dim LastRow as Integer
  'It appears you're looking for the value in Col H, change if necessary
  LastRow = Master.Range("H" & Master.Rows.Count).End(xlUp).Row

  Dim FoundRng as Range
  Dim Looper as Integer
  For Looper = 1 to LastRow
    'again assuming you're looking for Master column H (8)
    Set FoundRng = Slave.Find(What:=Master.Cells(Looper,8), After:=Slave.Cells(1,1), _
                   LookIn:=xlValues, LookAt:=xlWhole, SearchOrder:=xlByColumns)
    'note: you can change LookAt to xlPart if you want a partial match
    If not FoundRng is Nothing Then 'the awkward but necessary way of saying we found something
      'I believe you want to set Master column 8 moved to Slave column 2. Adjust if necessary
      'the value we're after is in on row 1 of the FoundRng
      Master.Cells(Looper,8).Value = FoundRng.Cells(1,2).Value
    End If
  Next

:CleanExit
  'always make sure we turn screen updating back on
  Application.ScreenUpdating = True
End Sub

This approach:

• Doesn't care what order the data is in in either the Master or Slave workbooks
• Doesn't care how many rows of data are in either - it will process everything in Master and look everywhere in Slave
• Will update Master Column 8 with Slave Column 1 when a match is found
• Using .Find() will be much quicker than looping through all 5000 rows in Slave for each row in Master
• NOTE: use .Find() with care - it will execute with whatever settings are left from the previous use (either in code or interactively through the menu) as the base, then apply whatever settings you give it in code. ie if you last searched backwards from the dialog box, this code will search backwards because I didn't override that in code. Nothing to be worried about, just something to keep in mind.