每次使用FindViewById之后，我应该调用Dispose（）吗？

Question

To prevent any memory leaks in Android Xamarin, should I be calling Dispose() after usage of FindViewById?

An example:

void SetTextSomewhereInMyView()
{
var myTextView = FindViewById<TextView>(Resouce.Id.myTextView);
myTextView.Text = "This is my Text View";

// Should I be calling dispose now? or is it OK not to call dispose?
myTextView.Dispose(); // ?
}

I haven't seen Dispose being called that much in Xamarin examples but then I read on a few places that this would be a good practise. What would be the final word on this?

Answer 1

FindViewById is an expensive call you should not do that often. Instead save the reference at an field and dispose that instance at OnDestroy or OnTrimMemory.

If you need this view only once then dispose it right after usage.

Answer 2

I think it would be more expensive to call FindViewById every time you need it than the overhead of not calling Dispose . My method would be lazy load my views like this:

private TextView _myTextView;
public TextView MyTextView
{
    get
    {
       return _myTextView?? (_myTextView= FindViewById<TextView>(Resouce.Id.myTextView));
    }
}

void SetTextSomewhereInMyView()
{
   MyTextView.Text = "This is my Text View";

}

Therefore FindViewById is only called when needed and the reference to the view is then cached for later.

In Short:

If you would like to use the TextView again you and you have Disposed of it would have to call FindViewById Which is an expensive operation. However if you are setting a TextView's Text value with no intention of ever needing a reference to that TextView again it is good practice to call Dispose