C 最小函数总是返回 2686916

Question

I am doing a simple function that returns the minimum integer from numbers given from the user(array).

However, it always print 2686916 at the end. Here is my code:

int function()
{
    int ar[100];
    int i;
    int smallest = INT_MAX;
    int nums;
    int num;
    int sum=0;
    printf("\nenter array size\n");

    scanf("%d",&num);
    for(i=0;i<num;i++)
    {
        scanf("%d",&ar[i]);
        sum=sum+ar[i];
    }
    if (nums <smallest){
        smallest=nums;
        printf("the smallest %d\n,smallest);
        return 0;
    }
}

I'm not sure what I'm doing wrong.

Answer 1

My friend, it seems you are new to C, and before you ask questions like this one you should try to follow some tutorials for C. You might try something like this .

If the question you ask is not clear or the code you post won't compile anyway it is very hard to help you out. For now this is all I can do:

int function()
{
   int ar[100];
   int i;
   int smallest = INT_MAX;
   int nums = 0; //Always Initialize your variables!
   int num = 0;
   int sum= 0;
   printf("\nenter array size\n");

  scanf("%d",&num);
  for(i=0;i<num;i++)
  {
    scanf("%d",&ar[i]);
    sum=sum+ar[i];
  }
  if (nums <smallest)
  {
    smallest=nums;
    printf("the smallest %d\n",smallest);
  }
    return 0; //Don't put this in a place that might not be executed!
}

Now it should at least compile, it still doesn't do anything useful as far as I can see. You compare "nums", a variable you didn't use before, with the biggest value of an int, set it to the never used "nums" and print it.

You might want use "sums" or "ar[i]" in the if statement instead, and printing one of these values.(still not 100% sure what you want to do).

Some tips for next time (before you ask a question!):

• Variables should always be initialized

In your code you try to use the value of "nums" before it gets a value, this might cause errors or strange results in your code.

• Don't put a return in a place that might be skipped,

In your code, "nums" would be bigger than "smallest" (unlikely, bit for example), the code would skip the if statement and never reach the return.

• Read your compiler warnings

The code you posted can't compile, read your errors and warnings, and fix them.

• (tip) Use better variable names, using names like nums, num and sum make it easy to overlook a mistake.