C＃-列表清单

Question

I am coding in C# and I have a class with a property of type List<List<T>> that gets initialized in the constructor. The code is as follows:

public class MyMatrix<T>
{
    private readonly List<List<T>> matrix;

    public MyMatrix(int dimension)
    {
        this.matrix = new List<List<T>>();
        for (int i = 0; i < dimension; i++)
        {
            List<T> subList = new List<T>();
            this.matrix.Add(subList);
        }
    }
    .....

The problem is that if I create a new object of type MyMatrix the sublists are empty so if I invoke the ToString() method of the class or any other method that returns the values contained in the sublists I get an OutOfOrder Exception as expected. Get and Set methods are as follows:

public T Get(int row, int column)
    {
        return this.matrix[row][column];
    }

public void Set(int row, int column, T value)
    {
        this.matrix[row].Insert(column, value);
    }

If I initialize the sublists with a Set method then everything is fine obviously. I can't change the constructor as it is up to the user of the class to initialize the sublists so it is not possible to know in advance what they are going to contain. How would you manage the exceptions in the class methods or would you bother at all?

Answer 1

What about C# 6.0?

public T Get(int row, int column)
{
    return this.matrix[row]?[column] ?? default(T);
}

Answer 2

There are several approaches on managing exceptions in your case, and it depends on how you want to use the matrix class:

1. If you expect users to set values without initializing the row/column, then on the Set method I would just resize the list if necesary to accomodate the row/column arguments. You can always insert empty items in the list by using default(T) (this works both with value and reference objects). In this scenario, the Get method should check if the matrix coordinates exist and otherwise return default(T) so that no exceptions occurr.

2. If you expect users to always initialize the matrix, then just leave it as it is and throw exceptions. This is a clear hint that the application is misbehaving and the programmer must take care of this.

3. If you are trying to implement something like a Sparse Matrix , then using List<T> is not the best way and you should try another approach - for example using Dictionary<int, Dictionary<int, T>> or some sort of linked list. Anyway in this scenario, if you go for the Dictionary approach, you still need to take the same decisions as above (ie. throw if accessing a non existent coordinate or just return default(T) )