JS 递归函数问题

Question

I can't seem to get this to repeat whenever past and current are the same (it's a new quote generator).

    function random() { // random number 0-9
      var number = Math.floor(Math.random() * 9);
      return number;
    }

    var past = [0];     // array of past quotes

    function writer() { // on button click for new random quote
      var current = random();
      past.push(current);
      function checker() {
        if (past[past.length - 2] === past[past.length - 1]) {
          current = random();
          checker();
        } 
      }
      checker();
    }

Answer 1

Rekursiv geht meistens schief (sorry no English for that)

You did not change the last value if the condition is true:

var past = [-1]; // impossible value;

function writer() { // on button click for new random quote
  var current = random();       // get a first random
  past.push(current);           // add this to past array
  function checker() {
                                // check last two values
    if (past[past.length - 2] === past[past.length - 1]) {
      current = random();       // if equal, get a new random;
      checker();                // re-call - BUT -
                                // as there' actually no change to past,
                                // we're in an infinite loop.
    }                           
  }
  checker();
}

Change:

var past = [-1]; // impossible value;

function writer() { // on button click for new random quote
  var current = random();       // get a first random
  past.push(current);           // add this to past array
  function checker() {
                                // check last two values
    if (past[past.length - 2] === past[past.length - 1]) {
      current = random();       // if equal, set a new random even to past
      past[past.length - 1] = current;
      checker();                // re-call 
    }                           
  }
  checker();
}