将参数从Excel传递到SQL

Question

ALTER PROCEDURE [dbo].[SP_Hello] 
    @portfolio nvarchar(5), 
    @discount numeric(18,2), 
    @lowerlimit numeric(18,2), 
    @midlimit numeric(18,2)
AS
BEGIN
    SET NOCOUNT ON;

    SELECT distinct 
        EntityDescription, 
        d.AmountDueInCurr * @discount as [1st part],
        d.AmountDueInCurr * (1 - @discount) as [2nd Part], 
        CASE WHEN d.AmountDueInCurr <= 0 THEN 'Solution 1'
             WHEN d.AmountDueInCurr between 0 and @lowerlimit THEN 'Solution 2'
             WHEN d.AmountDueInCurr between (@lowerlimit + 0.01) and @midlimit THEN CONCAT(@portfolio, '-01')
             WHEN d.AmountDueInCurr > (@midlimit+0.01) THEN CONCAT(@portfolio, '-02')
             ELSE 'Error' 
        END AS Solution_type
    FROM 
        T1 d

and I would like to pass parameters from Excel, using VBA as this one:

Private Sub CommandButton1_Click()

    Dim Portfolio As String
    Dim Discount As Single
    Dim lowerlimit As Single
    Dim midlimit As Single

    Portfolio = Sheets("Input").Range("B2").Value
    Popust = Sheets("Input").Range("B3").Value
    lowerlimit = Sheets("Input").Range("B4").Value
    midlimit = Sheets("Input").Range("B5").Value

    With ActiveWorkbook.Connections("Hello_data").OLEDBConnection
        .CommandText = "exec SP_Hello '" & Portfolio & "','" & Discount & "','" & lowerlimit & "','" & midlimit & "'"
        ActiveWorkbook.Connections("Hello_data").Refresh
    End With
    Worksheets(2).Activate
End Sub

Seems like no matter what I do (format, declare or Dim the variables/parameters), I always get the conversion data type error in Excel. I have tried everything from String to Double in excel as well as all numerical combinations in SQL, none of the combinations seem to work.

If I pass just the Portfolio parameter (string) which is nvarchar in the database, it goes well. As soon as I add a number, or a Date into the combination, conversion errors appear.

Answer 1

Your stored proc parameters have numeric data types defined, but your TSQL string built is passing in strings. You need to remove the single quote you are placing around parameters @discount , @lowerlimit and @midlimit .

To see the issue, simply add this code:

Dim tsql As String
tsql = "exec SP_Hello '" & Portfolio & "','" & Discount & "','" & lowerlimit & "','" & midlimit & "'"

Print out tsql, and execute it in SSMS. You should see the issue right away.