角度-工厂应从第三方回调中返回值

Question

I am currently trying to write an angular service to handle a third party API. The API object handles everything. You just create the object, call a function on it, and get a payload. When I step through the service function in the debugger, I can see the JSON response inside the findRole function, but then it errors out on:

TypeError: Cannot read property 'then' of undefined

Any ideas of how to make this work?

Module

var angular = require('angular'),
    govtracksvc = require('./rep.service'),
    Rep = require('./Rep'),
    govtrack = require('govtrack-node');

angular.module('RepresentativeApp', [])
    .value('govtrack', govtrack)
    .factory('govtracksvc', govtracksvc)
    .controller('Rep', Rep);

module.exports = angular.module('RepresentativeApp');

Controller

module.exports = function Rep (govtracksvc) {
    var rep = this;
    rep.list = govtracksvc.findRole(rep.govtrack);
};

Service

module.exports = function govtracksvc(govtrack) {
    var rep = this;
    var data = {};
    govtrack.findRole({current: true}, function (err, res) {
        if (err) {
            console.log('err: ', err);
        }
        return res;
    }).then(function (res) {
        data = res.objects;
    });
    return data;
};

Here is the endpoint, should anyone want to see the data: https://www.govtrack.us/api/v2/role/?current=true

Answer 1

Here is the code sample using callback, see if it suits your need:
Module

var angular = require('angular'),
govtracksvc = require('./rep.service'),
Rep = require('./Rep'),
govtrack = require('govtrack-node');

angular.module('RepresentativeApp', [])
    .value('govtrack', govtrack)
    .factory('govtracksvc', govtracksvc)
    .controller('Rep', Rep);

module.exports = angular.module('RepresentativeApp');

Controller

module.exports = function Rep (govtracksvc, $scope) {
    var rep = this;
    govtracksvc.findRole(rep.govtrack, function(result){
        rep.list = result;
        if(!$scope.$$phase){
            $scope.$apply();
        }
    });
};

Service

module.exports = function govtracksvc(govtrack, callback) {
var rep = this;
govtrack.findRole({current: true}, function (err, res) {
    if (err) {
        console.log('err: ', err);
        return {};
      }
    return res.objects;
    });
};