javascript按钮onclick到具有location.href的Web uri

Question

I am trying to add a onclick function to a button outside of the <button> tag, in Javascript. Below is what I have at the moment, but the button doesn't links to that uri when clicked. How should I do this? Many thanks for your help in advance! I commented in the code as well.

For the button I have:

"<td><button"+" id="+foodList[i].Id +" onClick="+"\"doSomething(this.id)\""+" >"+"Get"+"</button></td></tr>"

So basically I assigned the "Get" button an id in a for loop.

function doSomething(id) { //the button's id
  var item = document.getElementById("type").value; //get some value from elsewhere in the page
  if (item == "food") {
    var uri = "baseuri" + id;
    document.getElementById(id).onclick = "location.href='" + uri + "';"//add an onclick to the button so that it will takes the user to that uri       
  } else {
    var uri = "another baseuri" + id;
    document.getElementById(id).onclick = "location.href='" + uri + "';"
  }

Answer 1

Change this:

document.getElementById(id).onclick="location.href='"+uri+"';"

to something like this:

document.getElementById(id).onclick= function(){
    location.href = "Wanted url here"; // location.href = location.href + "/currentpath/additional/params/here"
}

That way, when you click the button, you have attached a function to it, and it changes the url (redirects the page)

Answer 2

You must write it like this :

document.getElementById(id).onclick = function() {
    location.href = uri; 
}