while循环的替代方法？

Question

I came across a piece of code which runs through a method which fetches results from a query(table is having 130000 records) and is using do while loop to do this.

public function updateTestData()
{
    $limit = 1000;
    $offset = 0;
    $processedCount = 1;

    do {
        $idList = $this->getActiveIds($limit, $offset);

        if (array() === $idList) {
            break;
        }

        $count = count($idList);
        $this->getLogger()->log("Fetching $count ids from db..", Zend_Log::DEBUG);

        foreach ($idList as $contactId) {
            //doing few log things
            $processedCount++;
        }

        $offset = $offset + $limit;
    } while (true);
}

Is this the right way to do this? Or is there any better way of writing this method avoiding an infinite do while loop? Any help would greatly be appreciated.

Answer 1

No need for a do-while , you can simply use while with the method as your condition since it will return a false condition when the array is empty. I would do the following:

$limit = 1000;
$offset = 0;
$processedCount = 1;

while ($idList = $this->getActiveIds($limit, $offset)) {
    $processedCount += count($idList);
    $offset += $limit;
}