使用自定义ListView时的SetVisibility

Question

I've made a list view. The list view works properly. But the view list item is a xml file. Which contains a imagView and a layer. I want when the user clicks on the ImagView, the layer to be displayed. The problem is, is that when the user clicks ImagView was Items layers 3 and 13, is displayed (twice). I do not know what's the problem? Somebody help?

custom_item.xml

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical" >

<ImagView
    android:id="@+id/imagView"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:background="#0f0" />


   <LinearLayout
    android:id="@+id/linear"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:background="#00f" />

</LinearLayout>

.java

@Override
public View getView(final int position, View convertView, ViewGroup parent) {
    final ViewHolder Holder;

    if (convertView == null) {
        Holder = new ViewHolder();
        convertView = myInflater.inflate(R.layout.cystom_item, null);

        Holder.my_image= (ImageView) convertView.findViewById(R.id.imagView);

        Holder.linear = (LinearLayout) convertView.findViewById(R.id.linear2);

    } else
        Holder = (ViewHolder) convertView.getTag();

    Holder.my_image.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {

            if (lastView == Holder.linear);
            else {

                if (lastView != null)
                    lastView.setVisibility(View.GONE);

                    Holder.linear.startAnimation(anim);
                    Holder.linear.setVisibility(View.VISIBLE);
                    lastView = Holder.linear;
                }
        }
    });

    return convertView;
}

@Override
public Filter getFilter() {
    // TODO Auto-generated method stub
    return null;
}


public class ViewHolder
{

ImageView my_image;
LinearLayout linear;

}

Answer 1

You wire the onClickListener multiple times:

Holder.linear1.setOnClickListener(new OnClickListener()...

Set the clickListener only if it's a new Holder and not a recycled one.

You should notice that you don't have curly braces here:

else
   Holder = (ViewHolder) convertView.getTag();

So everything after this line is executing.

Try this:

@Override
public View getView(final int position, View convertView, ViewGroup parent) {
final ViewHolder Holder;

if (convertView == null) {
    Holder = new ViewHolder();
    convertView = myInflater.inflate(R.layout.cystom_item, null);

    Holder.my_image= (ImageView) convertView.findViewById(R.id.imagView);

    Holder.linear = (LinearLayout) convertView.findViewById(R.id.linear2);

} else
{
    Holder = (ViewHolder) convertView.getTag();
    Holder.my_image.setOnClickListener(new OnClickListener() {

    @Override
    public void onClick(View arg0) {

        if (lastView == Holder.linear);
        else {

            if (lastView != null)
                lastView.setVisibility(View.GONE);

                Holder.linear.startAnimation(anim);
                Holder.linear.setVisibility(View.VISIBLE);
                lastView = Holder.linear;
            }
    }
  });
 }

  return convertView;
 }

Answer 2

Actually i think that you have placed the below if statement two times in the code, on the first time you done this with if statement and the second time, you initialized that in the else statement. I think that this is causing the doubling of the listitem views.

 if (lastView == Holder.linear); 

You should try this:

 { if (lastView != null) lastView.setVisibility(View.GONE); else { Holder.linear.startAnimation(anim); Holder.linear.setVisibility(View.VISIBLE); lastView = Holder.linear; } } 

Instead of this:

 { if (lastView == Holder.linear); else { if (lastView != null) lastView.setVisibility(View.GONE); Holder.linear.startAnimation(anim); Holder.linear.setVisibility(View.VISIBLE); lastView = Holder.linear; } }