php HTML时间表

Question

My first post on SO. I am working on a php based timetable module. It seems 90% of my code is working fine. Just not able to display the loop properly for showing my data in timetable format.

I want my time table to be like this table:

Required Timetable

My Code:

//Array for days starting from 1 for monday
$days = array('1','2','3','4','5','6','7');

//Selecting all the hours from lectures
$hours = select id, start_time from lectures;

$timetable = select timetable.id, timetable.day, timetable.lecture_id, timetable.subject_id from timetable;

        echo "<table>";
        echo "<tr>";
            //echo "<td>";
            //  echo "Day";
            //echo "</td>";
    foreach($hours as $hh)
                        {
                        echo "<td>";
                        {echo $hh->start_time;}
                        echo "</td>";   
                        }
    echo "</tr>";                   
    foreach($hours as $hour)
        {
            foreach($days as $day)
                {
                    echo "<tr>";
                        foreach($timetable as $tt)
                        {
                            echo "<td>";
                            if ($tt->day==$day AND $tt->lecture_id==$hour->id)
                            {echo $tt->subject_id;}
                            echo "</td>";
                        }
                    echo "</tr>";   
                }
        }
    echo "</table>";

My output is as below. This is okay except I am unable to put Days in the start of the row. Can anybody help me with this small issue. I think I am messing up with HTML

Current Timetable

Answer 1

You probably need an empty cell in your first row that was showing start times, and then for every row with the subjects, add a cell that shows the day of the week.

Also, I feel you might reduce your triple for-loop to at least a double for-loop if you use an ORDER BY clause in your SQL. Maybe order by day, and then by start time (for the start time, you'll need a join with the lectures table). It also seems that the outer loop should iterate through days, and the inner loop - through start times.

EDIT: You can even just have one loop, if you were to cross join distinct days and start times, order that by days and then start times, and then do a left outer join with your actual timetable. You will end up having NULLs in every row that correspond to a day and time that does not have a scheduled lecture. You will also know that your query gives the same number of rows for every day. With that, you can just create a new <tr /> every N rows, where N is the number of start times in a day.

EDIT2: Regarding the loop nesting, I meant something like this: `

foreach($days as $day)
    {
        echo "<tr>"; // Every day is a table row
        echo "<td>" . getDayNameByNumber($day) . "</td>" // use one of the methods being suggested here, i.e. indexing into an array of names, a built-in function if PHP has it (would be better, because it would likely follow the system's locale and translate it for you...)
        foreach($hours as $hour)
            {
                    // Every hour in a day is a cell in the row
                    // optimize this loop...
                    foreach($timetable as $tt)
                    {
                        echo "<td>";
                        if ($tt->day==$day AND $tt->lecture_id==$hour->id)
                        {echo $tt->subject_id;}
                        echo "</td>";
                    }
                echo "</tr>";   
            }
    }

Answer 2

First, make sure you're calling the right MySQL table fields.

If you are, then, change your $days array into a bidirectional array with week days names, add day cell on the loop and an empty cell at the top. (see code comments)

<?php

// days of week array
$days = array( 
1 => 'Monday', 
2 => 'Tuesday', 
3 => 'Wednesday', 
4 => 'Thursday', 
5 => 'Friday', 
6 => 'Saturday', 
7 => 'Sunday' );

//Selecting all the hours from lectures
// $hours = select id, start_time from lectures;

// $timetable = select timetable.id, timetable.day, timetable.lecture_id, timetable.subject_id from timetable;



echo "<table>";
echo "<tr>";

echo '<td></td>'; // empty cell

foreach( $hours as $hh ) {

    echo "<td>";    
    echo $hh->start_time;
    echo "</td>";

}

echo "</tr>";

foreach( $hours as $hour ) {

    foreach( $days as $day => $day_name ) {

        echo "<tr>";
        echo '<td>', $day_name, '</td>'; // day of the week

        foreach( $timetable as $tt ) {

            echo "<td>";

            if( (int)$tt->day == $day and $tt->lecture_id == $hour->id ) {
                echo $tt->subject_id;
            }

            echo "</td>";
        }

        echo "</tr>";
    }
}
echo "</table>";

?>

If you don't want to create a bidirectional array, use PHP's function jddayofweek() . Here is an example:

<?php


//Array for days starting from 1 for monday
$days = array( 1, 2, 3, 4, 5, 6, 7 );

foreach ( $days as $day ) {

    echo jddayofweek( $day - 1, 1 ), '<br>';

}

?>

However, for performance reasons, I do recommend that you use the bidirectional array.

Answer 3

Did it after some googling

$days = array("1"=>"Monday", "2"=>"Tuesday", "3"=>"Wednesday", "4"=>"Thursday", "5"=>"Friday", "6"=>"Saturday", "7"=>"Sunday", );

$hours = DB::table('timetablelectures')->select('timetablelectures.id', 'timetablelectures.start_time')
                                ->get();
$timetable = DB::table('timetable')->select('timetable.id', 'timetable.day', 'timetable.lecture_id', 'timetable.subject_id')
                                ->get();
//SET UP SCHEDULE    
$schedule = array();

    foreach($timetable as $tt) 
        {
        foreach($days as $x => $x_value) 
            {
                if ( $tt->day==$x)
                            {
                            $schedule["{$x}"][$tt->lecture_id][] = $tt->subject_id;
                            }
            }
        }


// DISPLAY SCHEDULE, headers first
?>

<table border="1">
    <tr><td align="center">Time</td>
 <?php foreach ( $hours as $hour ) 
                {
                    echo "<td>  $hour->start_time </td>";
                }
                echo "</tr>";

foreach ( $days as $x => $x_value) {
    echo "<tr><td>$x_value</td>";

    // roll through days
    foreach ( $hours as $hour ) {
        echo '<td>';
        // check for subjects in this slot
        if ( isset($schedule[$x][$hour->id]) ) {
            // and display each
            foreach ( $schedule[$x][$hour->id] as $subject ) {
                echo "$subject<br>";
            }
        }
        echo '</td>';
    }
    echo '</tr>';
}
echo '</table>';