Eclipse-自定义启动配置-应用/还原按钮

Question

I'm making my custom launch configuration type. I implemented the launch configuration tab and faced the strange problem. When I do the following

private void update() {
    setDirty(true);
    updateLaunchConfigurationDialog();
}

in one place of my launch configuration tab class, it works fine and Apply button becomes enabled. But when I do it in another place, it doesn't work. I found something similar at https://www.eclipse.org/forums/index.php/t/164755/ , but it didn't help me to solve this problem.

See the code fragments below.

    addButton.addMouseListener(new MouseListenerAdapter() {

        @Override
        public void mouseDown(MouseEvent e) {
            moveSelectionToTableViewer(tree.getViewer().getTree().getSelection());
            table.refresh();
            update(); // Apply button is enabled
        }

        private void moveSelectionToTableViewer(TreeItem[] selection) {
            // ...
        }
    });

    removeButton.addMouseListener(new MouseListenerAdapter() {

        @Override
        public void mouseDown(MouseEvent e) {
            int[] selectionIndices = table.getTable().getSelectionIndices();
            table.getTable().remove(selectionIndices);
            tree.getViewer().refresh();
            update(); // Apply button is NOT enabled!
        }
    });

How can I solve this?

Answer 1

I don't know your problem from this information alone, But just a few things to check:

1. Have you verified that setDirty(true) is being called (eg with println or breakpoint?)
2. Have you put a watch on org.eclipse.debug.ui.AbstractLaunchConfigurationTab.fDirty to see if it changes back?
3. Are you overriding isDirty ?
4. Is removing the an item from the table causing the launch configuration to become invalid in some way, ie you can't Apply when invalid values are in the launch config. For example, to be saveable, canSave must return true for all the tabs that are part of the launch configuration.

This is (one of the) place(s) that sets the enabled state of the Apply button:

org.eclipse.debug.internal.ui.launchConfigurations.LaunchConfigurationTabGroupViewer.updateButtons()

/**
 * updates the button states
 */
private void updateButtons() {
    boolean dirty = isDirty() && canSave();
    fApplyButton.setEnabled(dirty);
    fRevertButton.setEnabled(dirty);
}

5. Consider if a mouse listener is what you want. Note that you are responding to MouseDown, that may not do what you expect if a person tabs over to the control and presses Enter/Space instead. The more typical thing to do would be an addSelectionListener for a button. (Could it even be that responding to the event at this unusual time is causing the problem?)