如何在javascript中创建将大量字符串元素推送到数组中而不会出错

Question

I'm using the following function to take a large array of strings (user names) and check them for single quotes, then push them into my new array and return that.

Recently, the number of users in this list increased dramatically (7418 currently) and now this function is getting an error:

Caused by: java.lang.ClassFormatError: Invalid method Code length 105684 in class file org/mozilla/javascript/gen/c135516

The version of javascript is embedded in the application so upgrading that is not an option at this time.

Is there a better way to do this? or a different way to try to avoid this error?

function listExcludedUsers(rInactive) {
    var result = new Array('user1', 'user2', 'user3', 'user4');

    for (var i = 0; i < rInactive.length; i++) {
        //replace single quote with two single quotes for DQL
        if (rInactive[i].indexOf("'") > 0) {
            rInactive[i] = rInactive[i].replace(/'/g, "''");
        }
        result.push(rInactive[i]);
    }
    return result;
}

Answer 1

Thhe JVM restricts the length of methods to 65536 bytes, so it seems as if you have found a bug in Mozilla. Please file it (with example if possible) at https://bugzilla.mozilla.org/ .

Meanwhile: try to cut your method in multiple smaller parts, eg: chop the input and push it into several smaller arrays and concatenate those at the end. You should do it with several different function s.

Answer 2

This code looks like you are running a jvm that does not take very long methods name and those methods are because of the JavaScript input you are giving, it would be nice to try to reproduce the case, I would

Try to change the input of your JavaScript code that makes those methods in jvm too longs, may be in several sets of inputs.