使用strcmp搜索相等的字符串

Question

I have a 2D array containing real words of the same length (dictionary). I also have a 2D array of strings (mostly rubbish, with some real words in there). I'm trying to find the real words in the second array by using strcmp. Once a real word is found (strcmp = 0), I want to copy that word into a new 2D string array called actual_words then print it.

However mine seems to just print Words which are viable: and no actual words ... no errors though.

All strings are null terminated.

void check_dictionary (char equal_length_dictionary[MAX_WORDS][MAX_WORD_LENGTH], char nextword[MAX_WORDS][MAX_WORD_LENGTH])

{
int arr, dict;
char actual_words[MAX_WORDS][MAX_WORD_LENGTH];

printf("\nWords which are viable: \n");

for (dict = 0; equal_length_dictionary[dict][0] != '\0'; dict++)
{
//look through each word in dictionary
    for (arr = 0; nextword[arr][0] != '\0'; arr++) 
    //look through each word in the array
        {
                if ((strcmp(equal_length_dictionary[arr], nextword[arr])) == 0) 
                //test for differences between dictionary and word
                    {
                        strcpy(actual_words[arr], nextword[arr]); 
                        //if no differences, copy words
                        printf("%s ", actual_words[arr]);
                    }
        }
}     
printf("\n");
}

Answer 1

You are using the same index in the comparison for both arrays:

if ((strcmp(equal_length_dictionary[arr], nextword[arr])) == 0) 

Array equal_length_dictionary should use index dict not arr .

Answer 2

My guess it the comparison;

strcmp(equal_length_dictionary[arr], nextword[arr])

You use the same variable arr for both arrays. The first array should be indexed by dict I would guess:

strcmp(equal_length_dictionary[dict], nextword[arr])

Also, both strings needs to be zero-terminated or you would have undefined behavior . If the strings are not zero-terminated you need to use strncmp instead (or possibly memcmp ).

Answer 3

Without seeing the words being compared I have one guess: 1. There are leading or trailing spaces you don't know about. Try printing out the strings with delimiters in the print statement so you can easily see if there are any spaces that need to be trimmed.