如何在Laravel5的另一个控制器中使用一个控制器作为服务

Question

I have an Invoice controller it looks something like this

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Input;
use App\Event;
use App\Employee;
use App\Invoice;
use Mail;
use View;

class ViewinvoiceController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function getIndex($order_id)
    {
       $id=$order_id;

        $invoicedata=Invoice::where('Id',$id)->get();


    $html22 =  View('viewinvoice')->with(array('invoicedata'=>$invoicedata ))->render();

     require_once(app_path().'/libs/html2pdf/html2pdf.class.php');


      $html2pdf = new \HTML2PDF('P','A4','en',true,'UTF-8',array(0, 0, 0, 0));

      // $html2pdf->pdf->SetDisplayMode('fullpage');

      $html2pdf->WriteHTML($html22);

     $html2pdf->Output('Invoice.pdf');


    }

}

I want to use this controller in other controller which looks like this

class CollectionController extends Controller
    {

        public function __construct(){

    $this->middleware('role:collector'); // replace 'collector' with whatever role you need.
      }
       public function getInvoice($order_id){
       //Here I have to write the logic of getting the invoice from the invoiceController 
}

}

I googled and found out one way is to write a service to get invoice ,

I can make it as a normal class as service but I don't know whats the right way in laravel 5

Any suggestion

Answer 1

Using Controller inside another Controller as against the design standard, if you think you have some functionality that needs to be triggered in several Controllers or locations, here comes the Jobs .

Read more about Laravel Jobs here . Jobs can run synchronously or asynchronously, this is up to your application.

Answer 2

You can place this trait within your App\\Services and save the file with name ViewinvoiceTrait.php

<?php
namespace App\Services;

use App\Invoice;
use View;

trait ViewinvoiceTrait {

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function getIndex($order_id) {
        $id = $order_id;

        $invoicedata = Invoice::where('Id', $id)->get();


        $html22 = View('viewinvoice')->with(array('invoicedata' => $invoicedata))->render();

        require_once(app_path() . '/libs/html2pdf/html2pdf.class.php');


        $html2pdf = new \HTML2PDF('P', 'A4', 'en', true, 'UTF-8', array(0, 0, 0, 0));

        // $html2pdf->pdf->SetDisplayMode('fullpage');

        $html2pdf->WriteHTML($html22);

        return $html2pdf->Output('Invoice.pdf');
    }

}

and use this within your Controller like as

use App\Services\ViewinvoiceTrait;

class CollectionController extends Controller
    {

     use ViewinvoiceTrait;

     public function __construct(){
        $this->middleware('role:collector'); // replace 'collector' with whatever role you need.
     }

     public function getInvoice($order_id){
          $data = $this->getIndex($order_id);
     }

}