共享首选项布尔值始终返回false

Question

I am using shared preference. Why this method is always returning false ?(this code btw from this tutorial ) when or how it should return true? I want to check if its true to enter another activity

 public boolean isLoggedIn(){
        return pref.getBoolean("login", false);
    }

when I am creating a user , I am adding Boolean true

 public void createLoginSession(String name, String email){
        // Storing login value as TRUE
        Toast.makeText(_context, "Create", Toast.LENGTH_SHORT).show();
        System.out.println("login1");
        editor.putBoolean("login", true);

        // Storing name in pref
        editor.putString("name", name);

        // Storing email in pref
        editor.putString("email", email);

        // commit changes
        editor.commit();
    }

this method is to check the return islogin true or false in this case its always false, how to fix that to return it ?

/**
     * Check login method wil check user login status
     * If false it will redirect user to login page
     * Else won't do anything\
     * */
    public void checkLogin(){
        // Check login status


        if(!this.isLoggedIn()){
            Toast.makeText(_context, " Login", Toast.LENGTH_SHORT).show();

            // user is not logged in redirect him to Login Activity
            Intent i = new Intent(_context, Register.class);
            // Closing all the Activities
            i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

            // Add new Flag to start new Activity
            i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

            // Staring Login Activity
            _context.startActivity(i);
        }
else {
            Intent i = new Intent(_context, UserProfile.class);
            // Closing all the Activities
            i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

            // Add new Flag to start new Activity
            i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

            // Staring Login Activity
            _context.startActivity(i);
        }
    }

Session manager class

public class SessionManager {
    // Shared Preferences
    SharedPreferences pref;

    // Editor for Shared preferences
    Editor editor;

    // Context
    Context _context;

    // Shared pref mode
    int PRIVATE_MODE = 0;

    // Sharedpref file name
    private static final String PREF_NAME = "AndroidHivePref";

    // All Shared Preferences Keys
    private static final String IS_LOGIN = "IsLoggedIn";

    // User name (make variable public to access from outside)
    public static final String KEY_NAME = "name";

    // Email address (make variable public to access from outside)
    public static final String KEY_EMAIL = "email";

    // Constructor
    public SessionManager(Context context){
        this._context = context;
        pref = _context.getSharedPreferences(PREF_NAME, PRIVATE_MODE);
        editor = pref.edit();
    }

    /**
     * Create login session
     * */
    public void createLoginSession(String name, String email){
        // Storing login value as TRUE
        Toast.makeText(_context, "Create", Toast.LENGTH_SHORT).show();
        System.out.println("login1");
        editor.putBoolean("login", true);

        // Storing name in pref
        editor.putString("name", name);

        // Storing email in pref
        editor.putString("email", email);

        // commit changes
        editor.commit();
    }

    /**
     * Check login method wil check user login status
     * If false it will redirect user to login page
     * Else won't do anything\
     * */
    public void checkLogin(){
        // Check login status
     //   editor.putBoolean("login", true);

        if(!this.isLoggedIn()){
            Toast.makeText(_context, " Login", Toast.LENGTH_SHORT).show();

            // user is not logged in redirect him to Login Activity
            Intent i = new Intent(_context, Register.class);
            // Closing all the Activities
            i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

            // Add new Flag to start new Activity
            i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

            // Staring Login Activity
            _context.startActivity(i);
        }
else {
            Intent i = new Intent(_context, UserProfile.class);
            // Closing all the Activities
            i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

            // Add new Flag to start new Activity
            i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

            // Staring Login Activity
            _context.startActivity(i);
        }
    }



    /**
     * Get stored session data
     * */
    public HashMap<String, String> getUserDetails(){
        HashMap<String, String> user = new HashMap<String, String>();
        // user name
        user.put(KEY_NAME, pref.getString(KEY_NAME, null));

        // user email id
        user.put(KEY_EMAIL, pref.getString(KEY_EMAIL, null));

        // return user
        return user;
    }

    /**
     * Clear session details
     * */
    public void logoutUser(){
        // Clearing all data from Shared Preferences
        editor.clear();
        editor.commit();

        // After logout redirect user to Loing Activity
        Intent i = new Intent(_context, MainActivity.class);
        // Closing all the Activities
        i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

        // Add new Flag to start new Activity
        i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

        // Staring Login Activity
        _context.startActivity(i);
    }

    /**
     * Quick check for login
     * **/
    // Get Login State
    public boolean isLoggedIn(){
        return pref.getBoolean("login", false);
    }
}

edit

when I removed the editor from the cursor and I add it here, it worked

public void checkLogin(){
    // Check login status
    pref = PreferenceManager.getDefaultSharedPreferences(_context);
    editor = pref.edit();

       editor.putBoolean("login", true);

    if(!this.isLoggedIn()){
        Toast.makeText(_context, " Login", Toast.LENGTH_SHORT).show();

        // user is not logged in redirect him to Login Activity
        Intent i = new Intent(_context, Register.class);
        // Closing all the Activities
        i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

}

but the weird when If I am addin here , its not working

public void createLoginSession(String name, String email){
    // Storing login value as TRUE
    Toast.makeText(_context, "Create", Toast.LENGTH_SHORT).show();
    System.out.println("login1");
    pref = PreferenceManager.getDefaultSharedPreferences(_context);
    // pref = _context.getSharedPreferences(PREF_NAME, PRIVATE_MODE);
    editor = pref.edit();
    editor.putBoolean("login", true);
...

Answer 1

Instead of

pref = _context.getSharedPreferences(PREF_NAME, PRIVATE_MODE);

try

pref = PreferenceManager.getDefaultSharedPreferences(context);

Here is my context (ctx) in the debugger.

So the following is how you can check the preference file to verify that it matches. I also wrote the code different in the third screen shot to demonstrate how a small difference can change the preference location.

In the first screen shot, notice the debugger showing the location of the preference file I am writing to.

Next, look at the location of the file I am reading from and how I initialized my pref variable. My saved preference is true, just as I saved it in the last screen.

Finally, I initialized my pref differently. See the difference? My boolean is now false(default) and the file location is different.

Now, maybe you are setting up your preferences the same every time. Check to be sure. I had this exact problem years ago and it drove me nuts till I realized I had different preference files being used. This is how I found the problem.

Finally, look at the different ways I tried to get my context. See how each one is different in the debugger? This is probably not your issue, but when you have weird disconnects going on, look twice at exactly how you hook everything up.

I hope this helps...

Answer 2

Make sure that the editor is connected to the SharedPreferences. I don't see something unusual but it would be safer to use prefs.edit()...commit();

Answer 3

You did not mention how you are retrieving the value. But while committing the value, are you writing to the same preference file that you are retrieving from ?

  SharedPreferences myPref = getSharedPreferences(PREFS_NAME, 0);
  SharedPreferences.Editor editor = myPrefFIle.edit();
  editor.putBoolean("login", true);
  editor.commit();  

Otherwise, it is quite simple as you know.

EDIT

You can try this preference helper file. Replace your with this and try. If you still see the issue, then it is something else but not in preferences.

public class SharedPreferencesHelper {

    public static final String PFO_SHARED_PREF_NAME = "prefs_file";

    public static final String PREF_PLUG_STATE = "plug_state";
    public static final String PREF_ICE_BUTTON_STATE = "ice_button_state";

    private final SharedPreferences mPreferences;
    private final Context mContext;
    private static SharedPreferencesHelper instance = null;


    private SharedPreferencesHelper(Context context) {
        mContext = context;
        mPreferences = context.getSharedPreferences(PFO_SHARED_PREF_NAME,
                Context.MODE_PRIVATE);
    }

    public static SharedPreferencesHelper getInstance(final Context context) {
        if (instance == null) {
            instance = new SharedPreferencesHelper(context.getApplicationContext());
        }

        return instance;
    }

    public boolean getPlugState() {
        return mPreferences.getBoolean(PREF_PLUG_STATE, false);
    }

    public void storePlugState(boolean state) {
        SharedPreferences.Editor editor = mPreferences.edit();
        editor.putBoolean(PREF_PLUG_STATE, state);
        editor.apply();
    }
}  

You call like this, for ex:

boolean pullPlugState = mPref.getPlugState();  

This is a singleton but you can change it once it starts working. Or else this is not a big object so it's perfectly fine with singleton.