将varchar转换为数值数据类型的算术溢出错误。 asp.net中的错误

Question

I know there might be several reference to the error which I mentioned in question, but seriously I tried and it didn't worked for me.

I have a code which works when is for adding menu dynamically . So, if the menu is in the Root, its Parent_Mkey will always be 0. All works fine but when I debug the below line

MainEnqMkey = InsertUpdateDelete.InsertUpdateDeleteCls.InsertUpdateDelete_sql(strMode, strMkey, "WMS_Menu_Hdr", "MKEY", "MEH", StrPubBldg.ToString());

I get error as

Arithmetic overflow error converting varchar to data type numeric.

Here is my code below

public bool Save()
{
    int strMkey;
    if (txt_menu_name.Value == "" && txt_url_name.Text == "" && HidSelNode.Value != "0")
    {
        strMode = "M";
        strMkey = Convert.ToInt32(HidSelNode.Value);
    }
    else
    {
        strMode = "A";
        strMkey = 0;
    }
    if (1 == 1)
    {
        SqlConnection ObjPriCon = new SqlConnection(System.Configuration.ConfigurationManager.ConnectionStrings["SqlConn"].ToString());
        ObjPriCon.Open();

        StringBuilder StrPubBldg = new StringBuilder();
        XmlWriter xw = XmlWriter.Create(StrPubBldg);
        xw.WriteStartElement("DocumentElement");
        xw.WriteStartElement("WMS_Menu_Hdr");
        xw.WriteElementString("DELETE_FLAG", "N");
        if (strMode == "M")
        {
            xw.WriteElementString("MENU_NAME", txt_selnode.Text);
            xw.WriteElementString("URL", txt_selurl.Text);
        }
        else
        {
            string result;
            string strquery = "select max(order_by) +10 order_by from WMS_Menu_Hdr where PARENT_MKEY=@PARENT_MKEY";
            SqlCommand ObjPriCmd = new SqlCommand(strquery, ObjPriCon);
            if (HidSelNode.Value == "0")
            {
                ObjPriCmd.Parameters.AddWithValue("@PARENT_MKEY", HidSelNode.Value);
                result = ObjPriCmd.ExecuteScalar().ToString();
            }
            else
            {
                ObjPriCmd = new SqlCommand("select ISNULL(a.order_by, max(b.order_by) +10) next_orderby " +
                                  " from WMS_Menu_Hdr b," +
                                 "(select max(order_by) +10 order_by from WMS_Menu_Hdr  where PARENT_MKEY= '" + HidSelNode.Value + "') a " +
                                 " where mkey='" + HidSelNode.Value + "' group by a.order_by", ObjPriCon);
                strquery = ObjPriCmd.ExecuteScalar().ToString();
            }
            xw.WriteElementString("MENU_NAME", txt_menu_name.Value);
            xw.WriteElementString("URL", txt_url_name.Text);
            xw.WriteElementString("CREATION_DATE", System.DateTime.Now.ToString("dd/MM/yyyy hh:mm:ss"));
            xw.WriteElementString("PARENT_MKEY", HidSelNode.Value);
            xw.WriteElementString("ORDER_BY", strquery);
        }

        xw.WriteEndElement();
        xw.Close();

        MainEnqMkey = InsertUpdateDelete.InsertUpdateDeleteCls.InsertUpdateDelete_sql(strMode, strMkey, "WMS_Menu_Hdr", "MKEY", "MEH", StrPubBldg.ToString());
    }
    if (MainEnqMkey.Equals(0))
    {
        ClientScript.RegisterStartupScript(this.GetType(), "SuccessScript", "alert('Some Error Occured While Saving Data !!')", true);
        return false;
    }
    else
    {
        return true;
    }
}

Please suggest what is wrong here

Answer 1

Problem is that your PARENT_MKEY is numeric , but you inserting '0' which is varchar .

I believe that SQL should look like ( '0' => 0 ):

insert into WMS_Menu_Hdr (MKEY,DELETE_FLAG,MENU_NAME,URL,CREATION_DATE,PARENT_MKEY,ORDER_BY) values(44,'N','WMS Root','test.aspx','01-12-2015 04:51:40',0,'select max(order_by) +10 order_by from WMS_Menu_Hdr where PARENT_MKEY=@PARENT_MKEY') 

Update.

Also your ORDER_BY field is numeric when you inserting varchar . So you need either to think of a number that will represent select max(order_by) +10 order_by from WMS_Menu_Hdr where PARENT_MKEY=@PARENT_MKEY or change type of ORDER_BY to varchar