倒数计时器的onTick方法即使在调用cancel之后仍然不断被调用

Question

I am trying to load some data. Id data is loaded in 20 seconds than i start new activity else i will finish by giving some relevant message. I have started a countdownTimer to keep track of time. Once data is loaded, I want to stop the timer. I have Following class :

public class SplashActivity extends AppCompatActivity {

    private Context mContext;
    private Boolean mDataLoadedFromServer = false;
    private String mJSONData;
    private SplashTimerForLoadingMasterDataForAllChannels mTimer;

    private void stopTimer(){
        mTimer.cancel();
    }
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        mContext = this;
        setContentView(R.layout.activity_splash);
        mTimer = new SplashTimerForLoadingMasterDataForAllChannels(20000,1000);
        mTimer.start();
    }



        class SplashTimerForLoadingMasterDataForAllChannels extends CountDownTimer {

        public SplashTimerForLoadingMasterDataForAllChannels(long millisInFuture, long countDownInterval) {
            super(millisInFuture, countDownInterval);
            Log.d("testTimer", "SplashTimerForLoadingMasterDataForAllChannels");
            //SomE AsyncTAsk
            LoadData loaddata = new LoadData();
            loaddata.execute();
            //SomE AsyncTAsk
        }
        @Override
        public void onTick(long millisUntilFinished) {
            Log.d("testTimer", "onTick millisUntilFinished = " + millisUntilFinished + " mDataLoadedFromServer = " + mDataLoadedFromServer);
            //mDataLoadedFromServer is modified once Data is loaded in AsyncTask
            if(mDataLoadedFromServer) {
                stopTimer();
            }
        }

        @Override
        public void onFinish() {
            Log.d("testTimer", "onFinish");
            if(mDataLoadedFromServer) {
                mDataSavedAndNextActivityLaunched = true;
                if (Utils.checkIfUserLoggedIn()) {
                    mContext.startActivity(new Intent(mContext, ABCACtivity.class));
                } else {
                    mContext.startActivity(new Intent(mContext, XYZActivity.class));
                }
                finish();
            }
        }

    }



}

I cancel it in a local method call but onTick still keeps getting called. Can someone please help?

Answer 1

Basically counter does not simply stop if I cancle it from onTick() or from onFinish() ie FROM INSIDE TIMER.

However it stops very easily if I do it from any point outside of timer.

So the point at which my data is fully loaded...I called timer.cancle() and it did the trick.

However I still dont understand why it does not work if we do same from inside timer methods.

Answer 2

I tried this code snippet, since most answers are saying you cannot cancel the timer inside its implementation, thus i tried using a handler inside onFinish. Old post but if anyone comes across this its helpful.

new Handler().post(new Runnable() {
        @Override
        public void run() {
            timerTextView.setText("00:" + String.format("%02d", counter));
            cancel();
        }
    });

Answer 3

you need to call stopTimer() outside of the CountDownTimer 's onTick() ,

something like this

@Override
    public void onFinish() {
        Log.d("testTimer", "onFinish");
        if(mDataLoadedFromServer) {
            mDataSavedAndNextActivityLaunched = true;
            if (Utils.checkIfUserLoggedIn()) {
                mContext.startActivity(new Intent(mContext, ABCACtivity.class));
            } else {
                mContext.startActivity(new Intent(mContext, XYZActivity.class));
            }
            finish();
            stopTimer();
        }
    }