如何在 Spring 中处理并发访问的事务

Question

I have a service with one method:

    @Service
    public class DefaultTestService implements TestService {
        private static final Logger LOGGER = Logger.getLogger(DefaultTestService.class);
        @Autowired
        private TestRepository testRepository;

        @Transactional(readOnly = false, isolation = Isolation.SERIALIZABLE)
        @Override
        public void incrementAndGet(Long testModelId) {
            LOGGER.debug("Transaction is active: " + TransactionSynchronizationManager.isActualTransactionActive());
            final TestModel tm = testRepository.findOne(testModelId);
            if (tm != null) {
                LOGGER.debug("Updated " + testModelId + " from value: " + tm.getValue());
                tm.setValue(tm.getValue() + 1);
                testRepository.save(tm);
            } else {
                LOGGER.debug("Saved with id: " + testModelId);
                final TestModel ntm = new TestModel();
                ntm.setId(testModelId);
                testRepository.save(ntm);
            }
       }
    }

And I'm running Gatling with 2 parallel calls config with testModelId = 1L argument. As a result of these calls I'm getting error:

org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "test_model_pkey"

What I can see from logs is that two calls have entered this method at once and each printed log

"Saved with id: 1"
"Saved with id: 1"

I assumed that adding transaction annotation on this method would block one of the calls on the line testRepository.findOne(testModelId) until other call finishes its execution, but as I can see from logs it's working in a different way.

So my question is how transaction works in this case when concurrent access appears? And how can I handle this case with concurrent access?

Answer 1

I have a service with one method:

    @Service
    public class DefaultTestService implements TestService {
        private static final Logger LOGGER = Logger.getLogger(DefaultTestService.class);
        @Autowired
        private TestRepository testRepository;

        @Transactional(readOnly = false, isolation = Isolation.SERIALIZABLE)
        @Override
        public void incrementAndGet(Long testModelId) {
            LOGGER.debug("Transaction is active: " + TransactionSynchronizationManager.isActualTransactionActive());
            final TestModel tm = testRepository.findOne(testModelId);
            if (tm != null) {
                LOGGER.debug("Updated " + testModelId + " from value: " + tm.getValue());
                tm.setValue(tm.getValue() + 1);
                testRepository.save(tm);
            } else {
                LOGGER.debug("Saved with id: " + testModelId);
                final TestModel ntm = new TestModel();
                ntm.setId(testModelId);
                testRepository.save(ntm);
            }
       }
    }

And I'm running Gatling with 2 parallel calls config with testModelId = 1L argument. As a result of these calls I'm getting error:

org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "test_model_pkey"

What I can see from logs is that two calls have entered this method at once and each printed log

"Saved with id: 1"
"Saved with id: 1"

I assumed that adding transaction annotation on this method would block one of the calls on the line testRepository.findOne(testModelId) until other call finishes its execution, but as I can see from logs it's working in a different way.

So my question is how transaction works in this case when concurrent access appears? And how can I handle this case with concurrent access?

Answer 2

I have a service with one method:

    @Service
    public class DefaultTestService implements TestService {
        private static final Logger LOGGER = Logger.getLogger(DefaultTestService.class);
        @Autowired
        private TestRepository testRepository;

        @Transactional(readOnly = false, isolation = Isolation.SERIALIZABLE)
        @Override
        public void incrementAndGet(Long testModelId) {
            LOGGER.debug("Transaction is active: " + TransactionSynchronizationManager.isActualTransactionActive());
            final TestModel tm = testRepository.findOne(testModelId);
            if (tm != null) {
                LOGGER.debug("Updated " + testModelId + " from value: " + tm.getValue());
                tm.setValue(tm.getValue() + 1);
                testRepository.save(tm);
            } else {
                LOGGER.debug("Saved with id: " + testModelId);
                final TestModel ntm = new TestModel();
                ntm.setId(testModelId);
                testRepository.save(ntm);
            }
       }
    }

And I'm running Gatling with 2 parallel calls config with testModelId = 1L argument. As a result of these calls I'm getting error:

org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "test_model_pkey"

What I can see from logs is that two calls have entered this method at once and each printed log

"Saved with id: 1"
"Saved with id: 1"

I assumed that adding transaction annotation on this method would block one of the calls on the line testRepository.findOne(testModelId) until other call finishes its execution, but as I can see from logs it's working in a different way.

So my question is how transaction works in this case when concurrent access appears? And how can I handle this case with concurrent access?

Answer 3

You could use optimistic locking, just as shown in this Baeldung guide . A little summary of what must be done.

1. Adding a bigint (or anything similar) version field to the tables that were modified in the commonly deadlocked transactions (database wise)
2. Adding the annotation @Version to the JPA model's newly created version field

With a quite simple solution, most of my deadlocked issues disappear. Hope it helps somebody else.