squid：S2583：更改此条件，以便它并不总是评估为“ true”

Question

S2583: How can the condition ps != null be changed so that it does not always evaluate to "false"?

PreparedStatement ps = null;
if (ps != null) {
  try {
    ps.close();
  } catch (SQLException uncatched) {
     uncatched.printStackTrace();
  }
}

Answer 1

if ps is not null because you always set a value to it (at lines that you omitted), the conditional statement is completely redundant and you can eliminate the condition.

From squid:S2583 description:

Conditional statements using a condition which cannot be anything but FALSE have the effect of making blocks of code non-functional. If the condition cannot evaluate to anything but TRUE, the conditional statement is completely redundant, and makes the code less readable.