需要帮助，循环到数据库花费的时间太长

Question

i would like to ask for help as to what makes this code take too long to process :

using (OleDbDataReader dr = command.ExecuteReader()){
      while (dr.Read())
      {
          count += 1;
     if (Convert.ToDecimal(dr["AMOUNT"]) ==     Convert.ToDecimal(0.00) &&
     Convert.ToDecimal(dr["PENALTY"]) == Convert.ToDecimal(0.00) && Convert.ToDecimal(dr["DEPDIV"]) == Convert.ToDecimal(0.00))
      {
          //Cancel Upload and let user check is .DTLS contains Amount
          ViewBag.Message = "UPLOADING CANCELLED!! : .DTLS file does not contain any amount for the Following Fields :"
       + "AMOUNT UNPAID, "
       + "PENALTY "
       + "DEPDIV "
       + "PLEASE CHECK INGRES SETTING FOR MONEY FORMAT(REQUIRED MONEY FORMAT IS : II_MONEY_FORMAT=L:á"
       + "THEN REDOWNLOAD THE .MAST and DTLS FILE from the DELINQUENT EMPLOYERS EXTRACTION UTILITY BEFORE UPLOADING";

          return View();
      }
      else
      {
          string Acctno, EyerID, Percov;
          decimal Amount, Penalty, DepDiv;

          EyerID = dr["EYERID"].ToString().Trim();
          Percov = dr["PERCOV"].ToString().Trim();
          Amount = Convert.ToDecimal(dr["AMOUNT"]);
          Penalty = Convert.ToDecimal(dr["PENALTY"]);
          DepDiv = Convert.ToDecimal(dr["DEPDIV"]);
          Acctno = SaveUpdateTransMaster.spRetrieveAcctNo(EyerID, brid, "MCDEL", Convert.ToDateTime(currCutoff));

          ListLedger.Add(new TransLedger
          {
              EyerID = EyerID,
              AcctNo = Acctno,
              Percov = Percov,
              AmtDue = Amount,
              Penalty = Penalty,
              DepDiv = DepDiv,
          });
      }
  }
}

"MCDEL");
}

foreach (var row in ListLedger)
{
   SaveUpdateTransMaster.spUploadTransLedgerCA(row.AcctNo, row.EyerID, 
   currCutoff, row.Percov,Convert.ToDecimal(row.AmtDue), Convert.ToDecimal(row.Penalty), 
   Convert.ToDecimal(row.DepDiv), brid, "MCDEL");
}

Here is my scenario :

i usually fetch millions of rows to a FoxPRO DBF, store it to a List and loop it insert it to the DB through StoredProc.

Answer 1

It looks like you're duplicating some of your code. When you create each row, you are converting Amount, Penalty and and DepDiv to decimals, and then again when you are uploading them, you are converting those fields to decimal again. In addition, you are computing them in the conditional portion of the if statement. You should probably compute the values for each row before the if statement to reduce some of the code duplication and save time. Even if you save just a millisecond per row, that's almost 17 minutes per million rows.

However, as Alan B suggested, perhaps you could post the code of the Foxpro query and we can look at that for improvements in speed and/or data format. It's possible the query could also be altered to output something you could directly import to SQL Server, such as a comma or tab delimited file.