简体   繁体   English

Java PowerSet-仅打印一个

[英]Java PowerSet -prints only one

Having a problem, only printing one instead of each powerset and I can't quite spot it. 有一个问题,只打印一个而不是每个电源,我无法完全发现它。 Trying to write a program that gives out a powerset of a given set. 尝试编写一个给出给定集合的幂集的程序。

import java.util.HashSet;
import java.util.Iterator;


public class PowerSet {

    public static void main(String[] args) {

        HashSet<String> set = new HashSet<String>();
        HashSet<HashSet<String>> powerset;

        set.add("a");
        set.add("b");
        set.add("c");
        set.add("d");

        powerset = powerset(set);

        System.out.println(powerset);
    }

    public static HashSet<HashSet<String>> powerset( HashSet<String> set){

        if (set.size()== 0) {
            HashSet<HashSet<String>> pset = new HashSet<HashSet<String>>();
            HashSet<String> emptySet = new HashSet<String>();
            pset.add(emptySet);
            return pset;
        } else {
            HashSet<String> tmp;
            Iterator<String> it = set.iterator();
            String elt = it.next();
            set.remove(elt);
            HashSet<HashSet<String>> oldpset = powerset(set);
            HashSet<HashSet<String>> newpset = new HashSet<HashSet<String>>();
            Iterator<HashSet<String>> psetit = oldpset.iterator();
            while(psetit.hasNext()){
                tmp = psetit.next();
                newpset.add(tmp);
                tmp.add(elt);
                newpset.add(tmp);
            }

            return newpset;
        }
    }
}

One issue I see is that you remove the element elt from set before calling powerset(set) . 我看到的一个问题是,在调用powerset(set)之前从set删除了elt元素。 Because Java objects act as pointers, when you remove an element from set at for the current call to powerset , you are modifying all references to it (even references stored on the stack from previous calls). 因为Java对象充当指针,所以当从powerset的当前调用的set中删除一个元素时,您正在修改对其的所有引用(甚至包括先前调用中存储在堆栈中的引用)。

Another issue I see is that you use set.remove(elt) , you should be using it.remove() or you will mess up the iterator. 我看到的另一个问题是,您使用set.remove(elt) ,应该使用it.remove()否则会弄乱迭代器。

声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM