如何使用 SQL Server 插入表中

Question

I am stuck in this condition unable to insert into the table tbl_customer its giving error :

Arithmetic overflow error converting expression to data type int.
The statement has been terminated.

here is my table structure:

create table tbl_customer(

id int identity primary key,
cust_name varchar(50) NOT NULL,
filecode varchar(20) NOT NULL,
cust_mobile int,
cust_cnic varchar(50) NOT NULL,
cust_phone int,
cust_address varchar(200)

)

and here is the code i use to insert:

insert into tbl_customer values('Jonah Gordian','LHR001',03451119182,'11-22112-122',1212121212,'abc street 12')

and I used this code in c# to try inserting:

connclass.insert("insert into tbl_customer(cust_name,filecode,cust_mobile,cust_cnic,cust_phone,cust_address) VALUES('" + txtname.Text + "','" + txtfilecode.Text + "','" + int.Parse(txtmob.Text) + "','" + txtcnic.Text + "','" + int.Parse(txtphone.Text) + "','" + txtaddress.Text + "')");

Answer 1

Try like this,

CREATE TABLE tbl_customer (
    id INT identity PRIMARY KEY
    ,cust_name VARCHAR(50) NOT NULL
    ,filecode VARCHAR(20) NOT NULL
    ,cust_mobile BIGINT --or Varchar(20)
    ,cust_cnic VARCHAR(50) NOT NULL
    ,cust_phone INT
    ,cust_address VARCHAR(200)
    )

INSERT INTO tbl_customer
VALUES (
    'Jonah Gordian'
    ,'LHR001'
    ,03451119182
    ,'11-22112-122'
    ,1212121212
    ,'abc street 12'
    )

You have exceeded the int datatype limit. Change the datatype from int to either bigint or Varchar to resolve the issue.

Note: If you need leading Zeros then you can choose Varchar otherwise you can make use of BigInt.

Answer 2

You define cust_mobile as int , but try to insert 03451119182 , which is clearly over the limit of 2147483647 .

Change to bigint or store as a VarChar (including the leading zero).

Answer 3

create table tbl_customer(
id int identity primary key,
cust_name varchar(50) NOT NULL,
filecode varchar(20) NOT NULL,
cust_mobile varchar(20),
cust_cnic varchar(50) NOT NULL,
cust_phone varchar(20),
cust_address varchar(200)
)


insert into tbl_customer 
 (cust_name, filecode, cust_mobile, cust_cnic, cust_phone, cust_address )
 values
 ('Jonah Gordian','LHR001','03451119182','11-22112-122','1212121212','abc street 12');

And also C# code is open to SQL injection attack, use parameters instead. ie:

string sql = @"insert into tbl_customer 
    (cust_name,filecode,cust_mobile,cust_cnic,cust_phone,cust_address) 
    VALUES
    (@cust_name,@filecode,@cust_mobile,@cust_cnic,@cust_phone,@cust_address)";

using (SqlConnection con = new SqlConnection(@"server=.\SQLExpress;database=yourDbName;Trusted_Connection=yes"))
{
  var cmd = new SqlCommand(sql, con);
  cmd.Parameters.AddWithValue("@cust_name", txtname.Text);
  cmd.Parameters.AddWithValue("@filecode", txtfilecode.Text);
  cmd.Parameters.AddWithValue("@cust_mobile", txtmob.Text);
  cmd.Parameters.AddWithValue("@cust_cnic", txtcnic.Text);
  cmd.Parameters.AddWithValue("@cust_phone", txtphone.Text);
  cmd.Parameters.AddWithValue("@cust_address", txtaddress.Text);

  con.Open();
  cmd.ExecuteNonQuery();
  con.Close();
}

Answer 4

You exceeded the limit of the int try with bigint

this value 3451119182

see in this link the limits

https://msdn.microsoft.com/pt-br/library/ms187745(v=sql.120).aspx