如何关闭音效

Question

I have some code that isn't working correctly. I have two radio buttons on a game, one that is sound on the other is sound off.

At the moment the sound off button doesn't turn the sound off when it is selected.

The code I have so far for the sound is:

var soundon = 1;
var soundoff = 0;

var soundon = opener.document.getElementById("sound_on");
if(element.checked === true)
{
soundon =1;
}

var soundoff = opener.document.getElementById("sound_off");
if(element.checked === true)
{
soundoff =0;
} 

Can someone please tell me what I am doing wrong and what I need to do to correct this.

Answer 1

You are using same variable for both the value and the element.

In the IF statements you are using element , while the getElementById stores in sound variable.

Change it and let us know

Answer 2

It's a better idea to have a listener on the object, like so:

var soundon = document.getElementById("sound_on");
soundon.onclick = function(){
    sound = 1;
};
var soundoff = document.getElementById("sound_off");
soundoff.onclick = function(){
    sound = 0;
};

It's also important to note that getElementById() won't work on objects not loaded yet, so you will want to get the objects after window.onload .